Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: Bokeh 3.7 #6529

Merged
merged 2 commits into from
Mar 13, 2025
+8 −3
Merged

compat: Bokeh 3.7 #6529

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c13e7c4
Update datetime axis UI test
hoxbro Mar 7, 2025
6170af4
Filterwarning for now
hoxbro Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Loading
Loading status checks…
Update datetime axis UI test
@hoxbro
hoxbro committed Mar 7, 2025

Verified

This commit was signed with the committer’s verified signature.
hoxbro Simon Høxbro Hansen
GPG key ID: 87DCEC968C573DC2
Verified
Learn about vigilant mode
commit c13e7c461c90e020aa86ec93f5777cd91eebefd7
10 changes: 7 additions & 3 deletions holoviews/tests/ui/bokeh/test_callback.py
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@

import holoviews as hv
from holoviews import Curve, DynamicMap, Scatter
from holoviews.plotting.bokeh.util import BOKEH_GE_3_4_0
from holoviews.plotting.bokeh.util import BOKEH_GE_3_4_0, BOKEH_GE_3_7_0
from holoviews.streams import (
BoundsX,
BoundsXY,
@@ -220,8 +220,12 @@
assert s.xs == {'x': np.datetime64('2024-01-12T13:26:44.819277')}
assert s.xs == {'x': np.datetime64('2024-01-12T13:26:44.819277')}
assert len(s.ys) == 2
assert np.isclose(s.ys["y1"], 18.130705394191)
assert np.isclose(s.ys["y2"], 76.551867219917)
if BOKEH_GE_3_7_0:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the datetime x-axis has changed to add the year, squeezing the values a bit.

Before After
Screenshot From 2025-03-07 11-38-23 Screenshot From 2025-03-07 11-37-49

assert np.isclose(s.ys["y1"], 16.19603524229075)
assert np.isclose(s.ys["y2"], 68.38325991189429)
else:
assert np.isclose(s.ys["y1"], 18.130705394191)
assert np.isclose(s.ys["y2"], 76.551867219917)

wait_until(test, page)

@@ -439,7 +443,7 @@
locator = page.locator(".custom-button")
locator.click()
locator = page.locator(".bk-btn")
expect(locator.first).not_to_be_visible()

Check failure on line 446 in holoviews/tests/ui/bokeh/test_callback.py

GitHub Actions / ui:test-ui:ubuntu-latest 

TestPopup.test_callback_visible[chromium]

AssertionError: Locator expected not to be visible
Actual value: True 
Call log:
LocatorAssertions.not_to_be_visible with timeout 5000ms
  - waiting for locator(".bk-btn").first
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"
  -   locator resolved to <button type="button" class="bk-btn bk-btn-default"></button>
  -   unexpected value "visible"

@pytest.mark.parametrize("tool", ["box_select", "lasso_select", "tap"])
@pytest.mark.parametrize("popup_position", [