Font updates in new filters #20482
Merged
Font updates in new filters #20482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
reviewed
Apr 9, 2024
src/components/ha-label.ts
Outdated
| @@ -44,6 +44,7 @@ class HaLabel extends LitElement { | |||
| color: var(--ha-label-text-color); | |||
| --mdc-icon-size: 12px; | |||
| text-wrap: nowrap; | |||
| font-family: Roboto, sans-serif; | |||
There was a problem hiding this comment.
Why is this needed? It will use the font of it's parent now right?
There was a problem hiding this comment.
I'll revert it, especially since I can't find the place it didn't work in... :-) But I will fix ha-input-chip instead. That definitely needs it and it gets Arial if not using their font CSS variable. @bramkragten
There was a problem hiding this comment.
@bramkragten I reverted it. Waiting for your approval.
bramkragten
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Font updates in new filters
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: