Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font updates in new filters #20482

Merged
merged 2 commits into from
May 6, 2024
Merged

Font updates in new filters #20482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15e7cbe
Style changes
yosilevy Apr 9, 2024
aea977e
Fixes
yosilevy Apr 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/ha-label.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class HaLabel extends LitElement {
color: var(--ha-label-text-color);
--mdc-icon-size: 12px;
text-wrap: nowrap;
font-family: Roboto, sans-serif;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? It will use the font of it's parent now right?

Copy link
Contributor Author

@yosilevy yosilevy Apr 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll revert it, especially since I can't find the place it didn't work in... :-) But I will fix ha-input-chip instead. That definitely needs it and it gets Arial if not using their font CSS variable. @bramkragten

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bramkragten I reverted it. Waiting for your approval.

}
.content > * {
position: relative;
Expand Down
1 change: 1 addition & 0 deletions src/components/ha-menu-item.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class HaMenuItem extends MdMenuItem {

--md-sys-color-on-primary-container: var(--primary-text-color);
--md-sys-color-on-secondary-container: var(--primary-text-color);
--md-menu-item-label-text-font: Roboto, sans-serif;
}
:host(.warning) {
--md-menu-item-label-text-color: var(--error-color);
Expand Down
Loading