Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline condition summary messages in automation editor #22497

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

shodhan-rai
Copy link
Contributor

@shodhan-rai shodhan-rai commented Oct 23, 2024

Breaking change

Proposed change

This PR addresses issue #22478 by changing all occurrences of "Test if…" to just "If…" in the relevant strings
in frontend/src/translations/en.json for proper grammar and consistency in automations and scripts.

The following changes have been made:

  • Lines 3154 to 3155:

    • Changed: "Test if multiple conditions match"
    • To: "If multiple conditions match"
  • Lines 3169 to 3171:

    • Changed: "Test if no condition matches"
    • To: "If no condition matches"
    • Changed: "Test if 1 condition does not match"
    • To: "If 1 condition does not match"
    • Changed: "Test if none of {count} conditions match"
    • To: "If none of {count} conditions match"
  • Lines 3194 to 3195:

    • Changed: "Test if any condition matches"
    • To: "If any condition matches"
    • Changed: "Test if any of {count} {count, plural, one {condition} other {conditions}} matches"
    • To: "If any of {count} {count, plural, one {condition} other {conditions}} matches"
  • Line 3225:

    • Changed: "Test if template renders a value equal to true"
    • To: "If template renders a value equal to true"

Additionally, for the following strings that contain "Confirm…", I changed them to start with "If…" as well:

  • Line 3248: Changed "Confirm the..." to "If the..."
  • Line 3204: Changed "Confirm..." to "If..."
  • Line 3217: Changed "Confirm sun..." to "If the sun..."

These changes ensure proper grammar and consistency throughout the application.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

# No example configuration needed.

Additional information

This PR fixes or closes issue: fix #22478
This PR is related to issue or discussion: home-assistant/core#22478
Link to documentation pull request: (if applicable)

Checklist

  • The code change is tested and works locally.
  • There is no commented-out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@silamon silamon changed the title Fix issue #22478: Changed as requested Streamline condition summary messages in automation editor Oct 24, 2024
@silamon silamon merged commit eb69f95 into home-assistant:dev Oct 24, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change all "Test if…" conditions to just "If …" for proper grammar
2 participants