-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shortcut hint to assist dialog #23739
Merged
Merged
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silamon
added
the
Needs UX
Pull requests requiring a review from the Home Assistant design team
label
Jan 14, 2025
jpbede
force-pushed
the
assist-shortcut-hint
branch
2 times, most recently
from
January 16, 2025 08:00
f3f948a
to
5c32def
Compare
@jpbede This is a nice addition and aligned with other use cases in HA 👍 |
wendevlin
reviewed
Jan 20, 2025
wendevlin
reviewed
Jan 20, 2025
wendevlin
removed
the
Needs UX
Pull requests requiring a review from the Home Assistant design team
label
Jan 20, 2025
wendevlin
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @jpbede!
I agree @balloob, I merged it because of the Ok from Marcin. @marcinbauer85 can you please have another look and tell us your pro/cons about it? |
wendevlin
added a commit
that referenced
this pull request
Jan 28, 2025
This reverts commit d121b33.
balloob
pushed a commit
that referenced
this pull request
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add a shortcut hint to the assist dialog when it is opened via the topbar.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: