refactor: remove useless spread #3600
Merged
+6
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
- Coverage 94.71% 94.71% -0.01%
==========================================
Files 158 158
Lines 9555 9552 -3
Branches 2813 2789 -24
==========================================
- Hits 9050 9047 -3
Misses 505 505 ☔ View full report in Codecov by Sentry. |
exoego
commented
Oct 31, 2024
| @@ -80,7 +80,7 @@ class ClientRequestImpl { | |||
| let methodUpperCase = this.method.toUpperCase() | |||
|
|
|||
| const headerValues: Record<string, string> = { | |||
| ...(args?.header ?? {}), | |||
| ...args?.header, | |||
There was a problem hiding this comment.
Note) spread fallback is redundant
const a = undefined
console.log({ ...a, b: 1 })
// { b: 1}
There was a problem hiding this comment.
I put out a PR related to this.
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code