Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove useless spread #3600

Merged
merged 5 commits into from
Nov 1, 2024
+6 −9
Merged

refactor: remove useless spread #3600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d313008
refactor: remove useless spread
exoego Oct 31, 2024
ec8ad0a
refactor: remove useless spread fallback
exoego Oct 31, 2024
6e60503
refactor(adapter/lambda-edge): remove unneeded ternary operators
EdamAme-x Oct 31, 2024
a64c14e
refactor: remove useless fallback
exoego Oct 31, 2024
5bf29e2
Merge pull request #5 from EdamAme-x/patch-13
exoego Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/adapter/lambda-edge/handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ const createResult = async (res: Response): Promise<CloudFrontResult> => {
status: res.status.toString(),
headers: convertHeaders(res.headers),
body,
...(isBase64Encoded ? { bodyEncoding: 'base64' } : {}),
...(isBase64Encoded && { bodyEncoding: 'base64' }),
}
}

Expand Down
10 changes: 3 additions & 7 deletions src/client/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,8 @@ class ClientRequestImpl {
let methodUpperCase = this.method.toUpperCase()

const headerValues: Record<string, string> = {
...(args?.header ?? {}),
...(typeof opt?.headers === 'function'
? await opt.headers()
: opt?.headers
? opt.headers
: {}),
...args?.header,
Copy link
Contributor Author

@exoego exoego Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note) spread fallback is redundant

const a = undefined
console.log({ ...a, b: 1 })

// { b: 1}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put out a PR related to this.

exoego#5

...(typeof opt?.headers === 'function' ? await opt.headers() : opt?.headers),
}

if (args?.cookie) {
Expand Down Expand Up @@ -201,7 +197,7 @@ export const hc = <T extends Hono<any, any, any>>(
const req = new ClientRequestImpl(url, method)
if (method) {
options ??= {}
const args = deepMerge<ClientRequestOptions>(options, { ...(opts.args[1] ?? {}) })
const args = deepMerge<ClientRequestOptions>(options, { ...opts.args[1] })
return req.fetch(opts.args[0], args)
}
return req
Expand Down
3 changes: 2 additions & 1 deletion src/middleware/jsx-renderer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ const createRenderer =
? jsx(
(props: any) => component(props, c),
{
...{ Layout, ...(props as any) },
Layout,
...(props as any),
},
children as any
)
Expand Down
Loading