Restore attribute "refresh=morph" to flag turbo frames to reload during a page refresh #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng a page refresh. This adds a new turbo-frame attribute: `refresh`. When its value is `morph`: * It will reload the turbo frame with morphing during a page refresh. * It won't update the turbo frame with the server response. * It won't remove it if it's missing in the server response. This attribute was part of the original proposal we presented in Rails World, then we removed it [1], because we thought it wasn't needed. But after testing the library in different scenarios, we've found assuming certain behavior for all the remote frames was problematic since it implied being too clever about what you wanted to do with the frame. The new attribute makes for a simple behavior: * The default behavior will be the expected one: turbo frames will be morphed as any other element. If they get a new URL they will be reloadded, if the get deleted in the response, they will disappear, etc. * You can use the new attribute to flag the frames for which you want the special behavior. [1]: 0c6a95d
jorgemanrubia
force-pushed
the
flag-to-reload-frames
branch
from
0ca3228 to
9ff6e16
Compare
|
@jorgemanrubia I noticed that when you put In my testing it only morphs when the full page is doing a morphing refresh. |
|
@krschacht yes I agree that that would be more consistent. I'd appreciate if you can create an issue 🙏 . |
|
Done. Issue #1161 is tee'd up with a good example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new turbo-frame attribute:
refresh. When its value ismorph:An example where these frames are useful is pagination, or any scenario where you load new state in the screen that you want to preserve during page refreshes, but that you also want to reload because the user action might have affected them.
This attribute was part of the original proposal we presented in Rails World, then we removed it, because we thought it wasn't needed. But after testing the library in different scenarios, we've found that assuming certain logic for all the remote frames was problematic. We had to be too clever about what you wanted to do with the frame. The new attribute makes for a simpler story:
Follow up to #1019.