fix: Enhance test stability in drive_tests.js #993
Conversation
In the drive_tests.js file, I improved test stability by introducing steps in two test cases: "test drive to external link" and "test drive enabled by default; click link inside data-turbo='false'." The added calls ensure that the respective elements (e.g., "#drive_enabled_external" and "#drive_disabled") are present and visible before interacting with them, reducing the chances of element unavailability issues during test execution. This resolves test failures where elements were not immediately accessible, leading to test timeouts.
… navigation wait This commit reverts one of the changes made in commit 641947d where I replaced 'nextBody' with 'await page.click(#drive_disabled)'. The reason for this reversion is to stick to explicit waiting for page navigation to ensure that the page has fully transitioned to its new state before making assertions. The 'nextBody' function is used to achieve this waiting behavior, ensuring the reliability of our tests in certain scenarios.
|
@AfolabiOlaoluwa I don't think these changes are necessary. Playwright already automatically waits for an element to be available before performing an action like For more details, see https://playwright.dev/docs/actionability |
@afcapel test cases aren't passing despite. Should we rather leave it hanging and not fixed? So I am surprised why it is closed. The PR is not solely about |
|
@AfolabiOlaoluwa adding |
I think should have been the comments as a review of the PR rather than the PR being closed. I do think we need to be patient about closing PRs. I have made amends as I agree with some of your opinion clearly listed out on #993 (comment), @afcapel. |
|
Thanks @AfolabiOlaoluwa 👍 |
In the
drive_tests.jsfile, I improved test stability by introducing steps in two test cases: "test drive to external link" and "test drive enabled by default; click link inside data-turbo='false'."The added calls ensure that the respective elements (e.g.,
#drive_enabled_externaland#drive_disabled) are present and visible before interacting with them, reducing the chances of element unavailability issues during test execution.This resolves test failures where elements were not immediately accessible, leading to test timeouts.