Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhance test stability in drive_tests.js #993

Merged
merged 3 commits into from
Sep 14, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: Removed unnecessary page.waitForSelector from the PR '641947d'
  • Loading branch information
AfolabiOlaoluwa committed Sep 13, 2023
commit 17c214c772a310d08e4408f6ca08c38609950810
3 changes: 1 addition & 2 deletions src/tests/functional/drive_tests.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ test.beforeEach(async ({ page }) => {
})

test("test drive enabled by default; click normal link", async ({ page }) => {
await page.waitForSelector("#drive_enabled")
await page.click("#drive_enabled")
await nextBody(page)
assert.equal(pathname(page.url()), path)
Expand All @@ -28,7 +27,7 @@ test("test drive to external link", async ({ page }) => {
})

test("test drive enabled by default; click link inside data-turbo='false'", async ({ page }) => {
await page.waitForSelector("#drive_disabled")
await page.click("#drive_disabled")
await nextBody(page)
AfolabiOlaoluwa marked this conversation as resolved.
Show resolved Hide resolved

assert.equal(pathname(page.url()), path)
Expand Down