Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neuer Batterietyp SBS Unipower XL #1199

Merged
merged 12 commits into from
Sep 16, 2024
Merged

Neuer Batterietyp SBS Unipower XL #1199

merged 12 commits into from
Sep 16, 2024

Conversation

Snoopy-HSS
Copy link 

modified:   include/BatteryCanReceiver.h
modified:   include/BatteryStats.h
new file:   include/SBSCanReceiver.h
modified:   src/Battery.cpp
modified:   src/BatteryCanReceiver.cpp
modified:   src/BatteryStats.cpp
new file:   src/SBSCanReceiver.cpp
modified:   webapp/src/locales/de.json
modified:   webapp/src/locales/en.json
modified:   webapp/src/locales/fr.json
modified:   webapp/src/views/BatteryAdminView.vue

@Snoopy-HSS
Neuer Batterietyp SBS Unipower XL
9d82dac 
	modified:   include/BatteryCanReceiver.h
	modified:   include/BatteryStats.h
	new file:   include/SBSCanReceiver.h
	modified:   src/Battery.cpp
	modified:   src/BatteryCanReceiver.cpp
	modified:   src/BatteryStats.cpp
	new file:   src/SBSCanReceiver.cpp
	modified:   webapp/src/locales/de.json
    modified:   webapp/src/locales/en.json
	modified:   webapp/src/locales/fr.json
	modified:   webapp/src/views/BatteryAdminView.vue
@SW-Niko SW-Niko mentioned this pull request Sep 1, 2024
Closed
ranma
ranma reviewed Sep 1, 2024
View reviewed changes
src/SBSCanReceiver.cpp Outdated Show resolved Hide resolved
schlimmchen
schlimmchen requested changes Sep 4, 2024
View reviewed changes
Copy link
Member

@schlimmchen schlimmchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you implement HASS auto-discovery for this, which would make this feature complete?

src/SBSCanReceiver.cpp Outdated Show resolved Hide resolved
src/BatteryCanReceiver.cpp Outdated Show resolved Hide resolved
src/SBSCanReceiver.cpp Outdated Show resolved Hide resolved
@Snoopy-HSS
modified: src/BatteryCanReceiver.cpp
795a493 
	modified:   src/SBSCanReceiver.cpp
@Snoopy-HSS
modified: src/MqttHandleBatteryHass.cpp
d3a10cb 
    I can not test it, no Home Assistant Server in USE
schlimmchen
schlimmchen approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@schlimmchen schlimmchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is still one indention issue. I will take care of it.

@Snoopy-HSS
Copy link
Author

@ranma can you please review it?

ranma
ranma reviewed Sep 14, 2024
View reviewed changes
src/SBSCanReceiver.cpp Outdated Show resolved Hide resolved
@Snoopy-HSS
modified: src/SBSCanReceiver.cpp
fc57c82 
    added missing blank in comment
    change Debug output from INT to float for Voltage
@schlimmchen
Copy link
Member

@ranma Once your discussions are resolved, we can move this along. I will prioritize this over #1218, which will use index 6 as battery provider instead (currently, there is a conflict), and which is still lacking HASS autodiscovery.

@schlimmchen schlimmchen mentioned this pull request Sep 14, 2024
Merged
ranma
ranma approved these changes Sep 15, 2024
View reviewed changes
Copy link

@ranma ranma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schlimmchen schlimmchen merged commit 3fc4309 into hoylabs:development Sep 16, 2024
8 checks passed
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schlimmchen schlimmchen schlimmchen approved these changes

@ranma ranma ranma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snoopy-HSS @schlimmchen @ranma