Jbd bms support

[MoleBre]

First of all: also my thank to all the developers. You are doing a great job. This project is awesome.
Please be patient with my skills. Its my first time contributing to a project on github and it took me some time to understand the code more or less :-).

I copied the the jk-bms code and adapted it to the jbd-bms uart communication protocol as specified by the manufacturer.

The code is working with my setup via the rs485 interface of my jbd bms:

• JBD Smart BMS 8~21S
• esp32-s3-n16r8-wroom1 + TTL RS-485 Konverter Modul Max485 Adapter

This pull request is related to issue #467.

[schlimmchen]

Thanks for this contribution!

I looked at this some time ago and noticed that it needs some polishing. Minor stuff (commented code should be cleaned up, spaces/indention).

The other thing that is a little bit offputting is this:

I copied the the jk-bms code

However, I am not sure if I am willing to put in the time and effort to generalize and share code. It would be the right thing to do, though. I can also see that there are significant differences, so clearly, there will be a lot of new code. We could generalize the DataPointContainer using a template (the DataPoint's std::variant go into the template parameters, and the DataPointContainer needs at least the label as template parameter...). I think that would be a good idea.

You marked this as draft a couple of hours ago. Why is that? because of the conflicts in webapp_dist? Just clean webapp_dist and you are good, at least regarding the conflicts.

[MoleBre]

Hi Schlimmchen. Ich antworte mal kurz auf Deutsch.

Vielen Dank erstmal für deine Rückmeldung!

Den PR-Status "Draft" und "Open" hatte ich falsch verstanden. Ich habe es jetzt wieder auf "Open" zurückgeändert.

Ja, da hast du recht. Den Code aufzudoppeln ist nicht schön. Anders hätte ich deinen Jk-Bms Code jedoch anpassen müssen, damit ich ihn für das Jbd-Bms wiederverwenden kann. Das habe ich mich bei meinem ersten PR nicht getraut. Ich habe hier kein Jk-Bms zum testen und ich wollte keine Bugs in euren bestehenden Code einbauen. Das Risiko war mir zu hoch.

Ich habe die Test-Kommentare gelöscht und den Commit mit den Webapp-Files zurückgenommen. Die falschen Einrückungen konnte ich aber bei mir in VS Code nicht finden.

Gebe mir gerne Bescheid, wenn ich noch etwas anpassen soll.

BG.

[schlimmchen]

I'll tackle the required changes.

[schlimmchen]

Rebased onto current development and de-deplicated DataPointsContainer.

[schlimmchen]

@MoleBre Ich wollte mergen, als mir aufgefallen ist, dass die HASS autodiscovery fehlt. Kannst du da bitte zumindest die wichtigsten Werte nacharbeiten? Siehe MqttHandleBatteryHass.cpp.

[schlimmchen]

Zwei Drei Dinge sind hier noch zu tun:

• (1) HASS autodiscovery
• (2) der Battery Provider Index muss 6 werden um Neuer Batterietyp SBS Unipower XL #1199 auszuweichen
• (3) es muss nach dem Mergen von Neuer Batterietyp SBS Unipower XL #1199 nochmal ge-rebase't werden, wobei Konflikte zu beheben sein werden.

[schlimmchen]

Tested successfully against a SP22S003AL22S40A with firmware version 6.7

Issues:

• BatteryOneTemperature is actually the board's temperature. This might be specific to my model, so I am not changing it.
• There should be a third temperature sensor value, but it seems it is not communicated over the serial connection.
• Currents below ~800mA are not detected by the BMS at all (not an OpenDTU-OnBattery problem, just an observation).
• Could not test all alarms, but some, and also multiple at once.
• Did not check all HASS values, but some, and I assume the rest are good (maybe there is a typo somewhere...)

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.