-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust logging of can message identifiers to support extended frames #1262
Adjust logging of can message identifiers to support extended frames #1262
Conversation
So far we only worked with non-extended can message identifiers. In the deye can protocol there are also extended frames with extenden identifiers specified. To allow further testing we should log all identifiers in full length.
@PeterDietr könntest du das build von hier ausprobieren und die Nachrichten die in der Konsole auftauchen hier posten? |
@@ -140,7 +140,7 @@ void BatteryCanReceiver::loop() | |||
} | |||
|
|||
if (_verboseLogging) { | |||
MessageOutput.printf("[%s] Received CAN message: 0x%04X -", | |||
MessageOutput.printf("[%s] Received CAN message: 0x%X -", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even
MessageOutput.printf("[%s] Received %sCAN message: 0x%0*X -",
_providerName, (rx_message.extd?"extended":""), (rx_message.extd?8:4), rx_message.identifier);
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hallo Andreas,
hier die Konsolen Nachrichten. Der Speicher wurde zu dem Zeitpunkt entladen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Danke, das funktioniert wohl doch anders als ich dachte.
Sieht so aus als ob Deye doch nicht mit extended ids arbeitet sonder einfach nur die ID hochzählt pro Modul. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. |
So far we only worked with non-extended can message identifiers. In the deye can protocol there are also extended frames with extended identifiers specified. To allow further testing we should log all identifiers in full length.
Logging still looks like the same for pytes with victron protocol.