Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust logging of can message identifiers to support extended frames #1262

Closed
wants to merge 1 commit into from
Closed

Adjust logging of can message identifiers to support extended frames #1262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BatteryCanReceiver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ void BatteryCanReceiver::loop()
}

if (_verboseLogging) {
MessageOutput.printf("[%s] Received CAN message: 0x%04X -",
MessageOutput.printf("[%s] Received CAN message: 0x%X -",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe even

MessageOutput.printf("[%s] Received %sCAN message: 0x%0*X -",
    _providerName, (rx_message.extd?"extended":""), (rx_message.extd?8:4), rx_message.identifier);

?

Copy link

@PeterDietr PeterDietr Sep 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hallo Andreas,
hier die Konsolen Nachrichten. Der Speicher wurde zu dem Zeitpunkt entladen.

Protokoll Deye Speicher.txt

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke, das funktioniert wohl doch anders als ich dachte.

_providerName, rx_message.identifier);

for (int i = 0; i < rx_message.data_length_code; i++) {
Expand Down
Loading