Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix toast warning in SDL build #19660

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Fix toast warning in SDL build #19660

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052d0c3
Fix toast warning in SDL build
vishwamartur Nov 26, 2024
0a8ded5
Convert `argv[i]` to `Path` type before passing it to `File::IsDirect…
vishwamartur Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions SDL/SDLMain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
// SDL/EGL implementation of the framework.
// This is quite messy due to platform-specific implementations and #ifdef's.
// If your platform is not supported, it is suggested to use Qt instead.

#include <cstdlib>
#include <unistd.h>
#include <pwd.h>
Expand Down Expand Up @@ -1496,6 +1492,15 @@ int main(int argc, char *argv[]) {

bool waitOnExit = g_Config.iGPUBackend == (int)GPUBackend::OPENGL;

// Check if the path to a directory containing an unpacked ISO is passed as a command line argument
for (int i = 1; i < argc; i++) {
if (File::IsDirectory(Path(argv[i]))) {
// Display the toast warning
System_Toast("Warning: Playing unpacked games may cause issues.");
break;
}
}

if (!mainThreadIsRender) {
// Vulkan mode uses this.
// We should only be a message pump. This allows for lower latency
Expand Down
Loading