Fix toast warning in SDL build #19660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to hrydgard#18951 Add toast warning for unpacked ISO directories in SDL build. * Check if the path to a directory containing an unpacked ISO is passed as a command line argument. * Display the toast warning "Warning: Playing unpacked games may cause issues." if an unpacked ISO directory is detected.
hrydgard
approved these changes
Nov 26, 2024
|
This fails to build. Just fix it and I'll get it merged. |
…ory` * Fix the error by converting `argv[i]` to `Path` type before passing it to `File::IsDirectory`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #18951
Add toast warning for unpacked ISO directories in SDL build.