Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action bridge #1

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Conversation

v-lopez
Copy link

@v-lopez v-lopez commented Nov 13, 2020

No description provided.

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

@ipa-hsd Would you like to review, and if approved, merge this here, or should I open a new PR to https://github.com/ros2/ros1_bridge

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

@v-lopez I am currently reviewing it.

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

Thanks, I just pushed some changes that might have fixed the compilation in foxy.

I was building on rolling and the action client API had changed.

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

makes sense why I was having build issues and was not generating the interfaces anymore. When I made the PR it was successfully generating the interfaces and the bridge worked well. Thanks for the effort.

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

No problem.

There's still one more issue there, I just started a foxy docker and will try to fix it. Apologies for the confusion.

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

Should be ready now, let me know if you have any issues, I was able to build on foxy and rolling.

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

did you build the bridge against Foxy ? Dirk says it should be the master ros2#256 (comment). I am using the lastSuccessfulBuild

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

rolling are debians made from most recent changes, maybe master from a few days/weeks ago. Did you have any issues?

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

silly of me. I was just trying to avoid building ROS2 from source and still get the latest version. Will try the master.
https://index.ros.org//doc/ros2/Installation/Maintaining-a-Source-Checkout/#latest-development-branches

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

I finally had to build it against lastSuccessfulBuild since the master branches have compile errors. Your version of action_bridge compiles successfully now but most of the generated action interfaces are empty.

@ipa-hsd ipa-hsd#1 fixes build issues for me, and I get both ROS1 -> ROS2 and ROS2 -> ROS1 communication.

Which action interface did you test it for?

@v-lopez
Copy link
Author

v-lopez commented Nov 17, 2020

I tried with the tf msgs and control_msgs.

Which ones are missing?

@hsd-dev
Copy link
Owner

hsd-dev commented Nov 17, 2020

alright I installed control_msgs for Foxy and now it looks good. Ready to be merged!

@hsd-dev hsd-dev merged commit 469b025 into hsd-dev:action_bridge Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants