Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash if we fail to read the job ad #62

Closed
matyasselmeci opened this issue Apr 24, 2023 · 0 comments · Fixed by #66
Closed

Don't crash if we fail to read the job ad #62

matyasselmeci opened this issue Apr 24, 2023 · 0 comments · Fixed by #66
Assignees

Comments

@matyasselmeci
Copy link
Collaborator

We read and parse the job ad file in main.go:parse_job_ad() for getting Owner and ProjectName info of the job. It's not currently used (usage was removed in #50) but we plan to use it for telemetry in #41.

That function crashes (log.Fatal) if $_CONDOR_JOB_AD is set to a non-existent file, or if the job ad file exists but can't be read for some reason. This results in the job going on hold with the error message stash_plugin exited with code 1, unable to open output file .../.stash_plugin.out since the plugin doesn't write the output classad.

Don't exit out, just give a warning.

@timtheisen timtheisen self-assigned this Apr 25, 2023
@CohenQU CohenQU self-assigned this Apr 25, 2023
@timtheisen timtheisen removed their assignment Apr 25, 2023
@CohenQU CohenQU linked a pull request Apr 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants