Update parse_job_ad() and add TestParseJobAd() #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenQU
commented
Apr 26, 2023
CohenQU
commented
- The parse_job_ad function now prints a warning message instead of exiting if the job ad file cannot be found or read.
- A new TestParseJobAd function was added to test the parse_job_ad function in cases where the .job.ad file does not exist.
1. The parse_job_ad function now prints a warning message instead of exiting if the job ad file cannot be found or read. 2. A new TestParseJobAd function was added to test the parse_job_ad function in cases where the .job.ad file does not exist.
djw8605
requested changes
Apr 26, 2023
There was a problem hiding this comment.
The commit message isn't descriptive enough. Please update the commit message with the change in the normal code (something about non fatal when reading job ad), and put the change to the test below the top line commit message.
Could you change the jobad test name to something like "TestParseNoJobAd" so it's clear.
…ing with a fatal error when the .job.ad file cannot be found or read. This change makes the function more resilient to unexpected file issues, allowing the program to continue running despite the absence or inaccessibility of the .job.ad file. Add a new test function named TestParseNoJobAd to specifically test the parse_job_ad function's behavior when the .job.ad file does not exist. This test helps ensure that the function behaves as expected when handling missing or inaccessible job ad files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.