Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error OSX Mojave, PyBindings, virtual destructors #274

Closed
breznak opened this issue Feb 21, 2019 · 3 comments · Fixed by #276
Closed

Build error OSX Mojave, PyBindings, virtual destructors #274

breznak opened this issue Feb 21, 2019 · 3 comments · Fixed by #276
Labels
bug Something isn't working build

Comments

@breznak
Copy link
Member

breznak commented Feb 21, 2019

as reported by @pepedocs in
htm-community/nupic.py#7 (comment)
@breznak breznak added bug Something isn't working build labels Feb 21, 2019
This was referenced Feb 21, 2019
Closed
Closed
@breznak
Copy link
Member Author

breznak commented Feb 21, 2019

@pepedocs we do have a CI, have a look at OSX builds.
There seems to be something off with your build environment. Can you please post the output after running cmake?

@pepedocs
Copy link

@pepedocs we do have a CI, have a look at OSX builds.
There seems to be something off with your build environment. Can you please post the output after running cmake?

Hey here's my logs, I haven't had time to investigate them.

build

-- REPOSITORY_DIR       = /Users/admin/mlearn/nupic.cpp
-- CMAKE_BINARY_DIR     = /Users/admin/mlearn/nupic.cpp/build/scripts
-- CMAKE_BUILD_TYPE     = Debug
-- CMAKE_INSTALL_PREFIX = /Users/admin/mlearn/nupic.cpp/build/Release
-- FORCE_CPP11          = OFF
-- FORCE_BOOST          = OFF
-- BINDING_BUILD        = Python3
-- Environment var CXX  = 

-- CMAKE_CXX_COMPILER_ID= AppleClang
-- CMAKE_CXX_COMPILER_VERSION=10.0.0.10001044
-- CMAKE_CXX_COMPILER   = /Library/Developer/CommandLineTools/usr/bin/c++
-- INTERNAL_CPP_STANDARD= c++11
-- PLATFORM             = darwin
-- BITNESS              = 64
-- NEEDS_BOOST          = ON
-- INTERNAL_CXX_FLAGS   = -g;-fvisibility-inlines-hidden;-std=c++11;-stdlib=libc++;-fdiagnostics-show-option;-m64;-fPIC;-Wno-deprecated-register;-Werror;-Wextra;-Wreturn-type;-Wunused;-Wno-unused-variable;-Wno-unused-parameter;-Wno-missing-field-initializers;-Wall
-- INTERNAL_LINKER_FLAGS= -O0;-m64;-Wl,-undefined,error
-- COMMON_COMPILER_DEFINITIONS_STR= -DNTA_ASSERTIONS_ON -DHAVE_UNISTD_H -DNTA_COMPILER_CLANG
-- COMMON_OS_LIBS       = c++abi
-- external import
--    CMAKE_INSTALL_PREFIX  = /Users/admin/mlearn/nupic.cpp/build/ThirdParty
--    CMAKE_BUILD_TYPE      = Debug
--    EXTERNAL_CXX_FLAGS    = -fPIC
--    NEEDS_BOOST           = ON
--    BINDING_BUILD         = Python3
-- Obtaining yaml-cpp
-- obtaining Eigen
-- obtaining Boost
-- Obtaining gtest
-- obtaining PyBind11
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/admin/mlearn/nupic.cpp/build/ThirdParty
[ 87%] Built target yaml-cpp
[ 93%] Built target gtest
[100%] Built target gtest_main
-- Results from external build:
--   yaml-cpp_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-src/include
--   yaml-cpp_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a
--   eigen_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/eigen/eigen-src
--   BOOST_ROOT = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src
--   Boost_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src
--   Boost_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
--   gtest_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/gtest/googletest-src/googletest/include
--   gtest_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/gtest/googletest-build/googletest/libgtest$<$<CONFIG:Debug>:d>.a
--   pybind11_SOURCE_DIR = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src
--   pybind11_BINARY_DIR = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-build
-- Configuring nupic_core src
-- MERGE_STATIC_LIBRARIES LIB_TARGET=nupic_core, STATIC_LIBS = nupic_core_solo;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
-- MERGE_STATIC_LIBRARIES:     nupic_core_solo
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a - non-target lib.
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a - non-target lib.
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a - non-target lib.
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
-- Configuring nupic_core tests
-- Configuring Python interface
-- pybind11 v2.2.4
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/admin/mlearn/nupic.cpp/build/scripts
-- REPOSITORY_DIR       = /Users/admin/mlearn/nupic.cpp
-- CMAKE_BINARY_DIR     = /Users/admin/mlearn/nupic.cpp/build/scripts
-- CMAKE_BUILD_TYPE     = Debug
-- CMAKE_INSTALL_PREFIX = /Users/admin/mlearn/nupic.cpp/build/Release
-- FORCE_CPP11          = OFF
-- FORCE_BOOST          = OFF
-- BINDING_BUILD        = Python3
-- Environment var CXX  = 

-- CMAKE_CXX_COMPILER_ID= AppleClang
-- CMAKE_CXX_COMPILER_VERSION=10.0.0.10001044
-- CMAKE_CXX_COMPILER   = /Library/Developer/CommandLineTools/usr/bin/c++
-- INTERNAL_CPP_STANDARD= c++11
-- PLATFORM             = darwin
-- BITNESS              = 64
-- NEEDS_BOOST          = ON
-- INTERNAL_CXX_FLAGS   = -g;-fvisibility-inlines-hidden;-std=c++11;-stdlib=libc++;-fdiagnostics-show-option;-m64;-fPIC;-Wno-deprecated-register;-Werror;-Wextra;-Wreturn-type;-Wunused;-Wno-unused-variable;-Wno-unused-parameter;-Wno-missing-field-initializers;-Wall
-- INTERNAL_LINKER_FLAGS= -O0;-m64;-Wl,-undefined,error
-- COMMON_COMPILER_DEFINITIONS_STR= -DNTA_ASSERTIONS_ON -DHAVE_UNISTD_H -DNTA_COMPILER_CLANG
-- COMMON_OS_LIBS       = c++abi
-- external import
--    CMAKE_INSTALL_PREFIX  = /Users/admin/mlearn/nupic.cpp/build/ThirdParty
--    CMAKE_BUILD_TYPE      = Debug
--    EXTERNAL_CXX_FLAGS    = -fPIC
--    NEEDS_BOOST           = ON
--    BINDING_BUILD         = Python3
-- Obtaining yaml-cpp
-- obtaining Eigen
-- obtaining Boost
-- Obtaining gtest
-- obtaining PyBind11
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/admin/mlearn/nupic.cpp/build/ThirdParty
[ 87%] Built target yaml-cpp
[ 93%] Built target gtest
[100%] Built target gtest_main
-- Results from external build:
--   yaml-cpp_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-src/include
--   yaml-cpp_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a
--   eigen_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/eigen/eigen-src
--   BOOST_ROOT = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src
--   Boost_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src
--   Boost_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
--   gtest_INCLUDE_DIRS = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/gtest/googletest-src/googletest/include
--   gtest_LIBRARIES = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/gtest/googletest-build/googletest/libgtest$<$<CONFIG:Debug>:d>.a
--   pybind11_SOURCE_DIR = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src
--   pybind11_BINARY_DIR = /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-build
-- Configuring nupic_core src
-- MERGE_STATIC_LIBRARIES LIB_TARGET=nupic_core, STATIC_LIBS = nupic_core_solo;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a;/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
-- MERGE_STATIC_LIBRARIES:     nupic_core_solo
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a - non-target lib.
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a - non-target lib.
-- MERGE_STATIC_LIBRARIES:     /Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a - non-target lib.
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/yaml-cpp/yaml-cpp-build/libyaml-cpp.a
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_filesystem.a
-- ExpandStaticLib: LIB_TARGET=nupic_core_shared, src-lib=/Users/admin/mlearn/nupic.cpp/build/ThirdParty/boost/Boost_download-src/stage/lib/libboost_system.a
-- Configuring nupic_core tests
-- Configuring Python interface
-- pybind11 v2.2.4
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/admin/mlearn/nupic.cpp/build/scripts

install

[ 39%] Built target LibrarySource
[ 39%] Built target nupic_core_shared
[ 41%] Built target benchmark_hotgym
[ 42%] Built target nupic_core_solo
[ 44%] Built target nupic_core
[ 80%] Built target unit_tests
[ 80%] Building CXX object bindings/py/cpp_src/CMakeFiles/algorithms.dir/bindings/algorithms/py_SDR_Metrics.cpp.o
[ 39%] Built target LibrarySource
[ 39%] Built target nupic_core_shared
[ 41%] Built target benchmark_hotgym
[ 42%] Built target nupic_core_solo
[ 44%] Built target nupic_core
[ 80%] Built target unit_tests
[ 80%] Building CXX object bindings/py/cpp_src/CMakeFiles/algorithms.dir/bindings/algorithms/py_SDR_Metrics.cpp.o
In file included from /Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:22:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:43:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../attr.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/cast.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../pytypes.h:12:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/common.h:140:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/forward_list:171:
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'nupic::SDR_MetricsHelper_' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete __ptr;
    ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function 'std::__1::default_delete<nupic::SDR_MetricsHelper_>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2552:19: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_MetricsHelper_, std::__1::default_delete<nupic::SDR_MetricsHelper_> >::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1319:40: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_MetricsHelper_, std::__1::default_delete<nupic::SDR_MetricsHelper_> >::~unique_ptr' requested here
            v_h.holder<holder_type>().~holder_type();
                                       ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1054:26: note: in instantiation of member function 'pybind11::class_<nupic::SDR_MetricsHelper_>::dealloc' requested here
        record.dealloc = dealloc;
                         ^
/Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:36:40: note: in instantiation of function template specialization 'pybind11::class_<nupic::SDR_MetricsHelper_>::class_<>' requested here
        py::class_<SDR_MetricsHelper_> py_Helper(m, "SDR_MetricsHelper_");
                                       ^
In file included from /Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:22:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:43:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../attr.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/cast.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../pytypes.h:12:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/common.h:140:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/forward_list:171:
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'nupic::SDR_Sparsity' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete __ptr;
    ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function 'std::__1::default_delete<nupic::SDR_Sparsity>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2552:19: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_Sparsity, std::__1::default_delete<nupic::SDR_Sparsity> >::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1319:40: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_Sparsity, std::__1::default_delete<nupic::SDR_Sparsity> >::~unique_ptr' requested here
            v_h.holder<holder_type>().~holder_type();
                                       ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1054:26: note: in instantiation of member function 'pybind11::class_<nupic::SDR_Sparsity, nupic::SDR_MetricsHelper_>::dealloc' requested here
        record.dealloc = dealloc;
                         ^
/Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:52:54: note: in instantiation of function template specialization 'pybind11::class_<nupic::SDR_Sparsity, nupic::SDR_MetricsHelper_>::class_<char [490]>' requested here
        py::class_<SDR_Sparsity, SDR_MetricsHelper_> py_Sparsity(m, "SDR_Sparsity",
                                                     ^
In file included from /Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:22:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:43:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../attr.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/cast.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../pytypes.h:12:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/common.h:140:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/forward_list:171:
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'nupic::SDR_ActivationFrequency' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete __ptr;
    ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function 'std::__1::default_delete<nupic::SDR_ActivationFrequency>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2552:19: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_ActivationFrequency, std::__1::default_delete<nupic::SDR_ActivationFrequency> >::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1319:40: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_ActivationFrequency, std::__1::default_delete<nupic::SDR_ActivationFrequency> >::~unique_ptr' requested here
            v_h.holder<holder_type>().~holder_type();
                                       ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1054:26: note: in instantiation of member function 'pybind11::class_<nupic::SDR_ActivationFrequency, nupic::SDR_MetricsHelper_>::dealloc' requested here
        record.dealloc = dealloc;
                         ^
/Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:95:13: note: in instantiation of function template specialization 'pybind11::class_<nupic::SDR_ActivationFrequency, nupic::SDR_MetricsHelper_>::class_<char [731]>' requested here
            py_ActivationFrequency(m, "SDR_ActivationFrequency",
            ^
In file included from /Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:22:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:43:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../attr.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/cast.h:13:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/../pytypes.h:12:
In file included from /Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/detail/common.h:140:
In file included from /Library/Developer/CommandLineTools/usr/include/c++/v1/forward_list:171:
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2285:5: error: delete called on non-final 'nupic::SDR_Overlap' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete __ptr;
    ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2598:7: note: in instantiation of member function 'std::__1::default_delete<nupic::SDR_Overlap>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/memory:2552:19: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_Overlap, std::__1::default_delete<nupic::SDR_Overlap> >::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1319:40: note: in instantiation of member function 'std::__1::unique_ptr<nupic::SDR_Overlap, std::__1::default_delete<nupic::SDR_Overlap> >::~unique_ptr' requested here
            v_h.holder<holder_type>().~holder_type();
                                       ^
/Users/admin/mlearn/nupic.cpp/build/ThirdParty/pybind11/pybind11-src/include/pybind11/pybind11.h:1054:26: note: in instantiation of member function 'pybind11::class_<nupic::SDR_Overlap, nupic::SDR_MetricsHelper_>::dealloc' requested here
        record.dealloc = dealloc;
                         ^
/Users/admin/mlearn/nupic.cpp/bindings/py/cpp_src/bindings/algorithms/py_SDR_Metrics.cpp:154:53: note: in instantiation of function template specialization 'pybind11::class_<nupic::SDR_Overlap, nupic::SDR_MetricsHelper_>::class_<char [704]>' requested here
        py::class_<SDR_Overlap, SDR_MetricsHelper_> py_Overlap(m, "SDR_Overlap",
                                                    ^
4 errors generated.
make[2]: *** [bindings/py/cpp_src/CMakeFiles/algorithms.dir/bindings/algorithms/py_SDR_Metrics.cpp.o] Error 1
make[1]: *** [bindings/py/cpp_src/CMakeFiles/algorithms.dir/all] Error 2
make: *** [all] Error 2

@ctrl-z-9000-times
Copy link
Collaborator

Update: this issue is reproducible, by using Apple compiler Clang version 10, instead of the current v9 used by our current OS-X tests.

See PR #220 for compiler version update

@breznak breznak mentioned this issue Feb 22, 2019
Merged
3 tasks
pepedocs pushed a commit to pepedocs/nupic.cpp that referenced this issue Feb 22, 2019
Fix htm-community#274 compiler error for delete-non-virtual-dtor.
c807afe
@breznak breznak mentioned this issue Feb 22, 2019
Closed
@pepedocs pepedocs mentioned this issue Feb 22, 2019
Merged
breznak added a commit that referenced this issue Feb 22, 2019
@breznak
Merge pull request #276 from pepedocs/fix-use-virtual-dtor
a9cf77b 
Fix #274 compiler error for delete-non-virtual-dtor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working build
Projects
None yet
Milestone
No milestone
3 participants
@breznak @pepedocs @ctrl-z-9000-times