Fix #274 compiler error for delete-non-virtual-dtor. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breznak
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
yes, it's a correct fix.
Thanks for fixing it yourself and welcome to the repo with your first contribution 👍
It also fixes a bug for Clang 6.0 build.
The CI (OSX) will not detect it here, so I'll just merge and we verify in #220
|
Thanks you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a quick PR for this issue to fix the said build error.
I'm new to this code and haven't really had time so far to consider its logic if my fix would break something. However compile-wise this will fix the compiler error caused by delete-non-virtual-dtor option. There are other ways to fix this.
Please review.
@ctrl-z-9000-times @breznak
I confirm that I was able to install the nupic.cpp and nupic.py with this fix.
EDIT:
fixes #274
Fixes #262