Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1332 - Specify empty domain attribute handling. #1709

Merged
merged 3 commits into from
Oct 8, 2021
Merged

Fixes #1332 - Specify empty domain attribute handling. #1709

merged 3 commits into from
Oct 8, 2021

Conversation

miketaylr
Copy link
Collaborator

PTAL @sbingler.

(Not 100% sure I should set this to the canonicalized request-host, or the empty string, will think about it more tomorrow).

@miketaylr miketaylr changed the title Issue #1332 - Specify empty domain attribute handling. Fixes #1332 - Specify empty domain attribute handling. Oct 4, 2021
@miketaylr
Copy link
Collaborator Author

Note: this change intends to document what Safari and Firefox currently do, and I'll update WPTs to match once we land it.

chlily1
chlily1 reviewed Oct 4, 2021
View reviewed changes
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
sbingler
sbingler reviewed Oct 5, 2021
View reviewed changes
Copy link
Collaborator

@sbingler sbingler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped a couple thoughts in. To be clear, we're attempting to match Firefox's behavior here?

draft-ietf-httpbis-rfc6265bis.md Outdated Show resolved Hide resolved
chlily1
chlily1 approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@chlily1 chlily1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbingler
Copy link
Collaborator

sbingler commented Oct 6, 2021

LGTM

@miketaylr
Copy link
Collaborator Author

Thanks! Let me add a changelog entry, then I'll bother someone to merge this.

@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Oct 8, 2021
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 8, 2021
@miketaylr @chromium-wpt-export-bot
Switch assertion in test=42 to follow latest 6265bis update.
c2140a3 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 8, 2021
@miketaylr @chromium-wpt-export-bot
Switch assertion in test=42 to follow latest 6265bis update.
33f29c7 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
@chlily1 chlily1 merged commit bc3fc24 into httpwg:main Oct 8, 2021
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 12, 2021
@miketaylr @chromium-wpt-export-bot
Switch assertion in test=42 to follow latest 6265bis update.
b345ae1 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 12, 2021
@miketaylr @chromium-wpt-export-bot
Switch assertion in test=42 to follow latest 6265bis update.
20ce927 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 12, 2021
@miketaylr @chromium-wpt-export-bot
Switch assertion in test=42 to follow latest 6265bis update.
23f848c 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 13, 2021
@miketaylr @chromium-wpt-export-bot
Update some domain tests to follow latest 6265bis update.
3b83746 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 14, 2021
@miketaylr @chromium-wpt-export-bot
Update some domain tests to follow latest 6265bis update.
26cd98a 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Oct 14, 2021
@miketaylr @chromium-wpt-export-bot
Update some domain tests to follow latest 6265bis update.
58dba96 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Oct 14, 2021
@miketaylr
Update some domain tests to follow latest 6265bis update.
3813959 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Oct 28, 2021
@miketaylr @moz-wptsync-bot
Bug 1734753 [wpt PR 31162] - Update some domain tests to follow lates…
07c38b5 
…t 6265bis update., a=testonly

Automatic update from web-platform-tests
Update some domain tests to follow latest 6265bis update.

Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}

--

wpt-commits: 58dba963a5607ef657943e21b16a416109e422b0
wpt-pr: 31162
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Oct 28, 2021
@miketaylr @moz-wptsync-bot
Bug 1734753 [wpt PR 31162] - Update some domain tests to follow lates…
b5cabb6 
…t 6265bis update., a=testonly

Automatic update from web-platform-tests
Update some domain tests to follow latest 6265bis update.

Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}

--

wpt-commits: 58dba963a5607ef657943e21b16a416109e422b0
wpt-pr: 31162
Gabisampaio pushed a commit to Gabisampaio/wpt that referenced this pull request Nov 18, 2021
@miketaylr @Gabisampaio
Update some domain tests to follow latest 6265bis update.
86b7dfa 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@miketaylr @copybara-github
Update some domain tests to follow latest 6265bis update.
aa09380 
Also, add a few more tests inspired by bingler@'s GitHub comments.

Previously, the cookie spec left an empty domain attribute as
undefined behavior with SHOULD-level guidance.
httpwg/http-extensions#1709 changes the
spec to require handling of a cookie as a host cookie when its
last domain attribute is empty. This matches the current behavior
of Firefox and Safari.

See httpwg/http-extensions#1332 for
more discussion.

Change-Id: Ibf4f243c929b11768ff406e940d6988a37434754
Bug: 1255273
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203692
Reviewed-by: Steven Bingler <[email protected]>
Commit-Queue: Mike Taylor <[email protected]>
Cr-Commit-Position: refs/heads/main@{#931471}
NOKEYCHECK=True
GitOrigin-RevId: 3813959c16bf46f428c7691a8e1a916538793e4a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlily1 chlily1 chlily1 approved these changes

@mikewest mikewest Awaiting requested review from mikewest mikewest is a code owner

@johnwilander johnwilander Awaiting requested review from johnwilander johnwilander is a code owner

@sbingler sbingler Awaiting requested review from sbingler sbingler is a code owner

Assignees
No one assigned
Labels
6265bis
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miketaylr @sbingler @chlily1