Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SharedDDP as it was deprecated from Transformers. #1443

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Remove SharedDDP as it was deprecated from Transformers. #1443

merged 2 commits into from
Oct 12, 2023

Conversation

AdamLouly
Copy link
Contributor

The use of SharedDDP was deprecated in Transformers, and because Optimum trainer relies on it, it must be removed from Optimum.

The transformers PR:
huggingface/transformers#25702

JingyaHuang
JingyaHuang approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@JingyaHuang JingyaHuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @AdamLouly for the PR, let's get it merged.

@JingyaHuang JingyaHuang merged commit 5192682 into huggingface:main Oct 12, 2023
43 of 52 checks passed
@JingyaHuang JingyaHuang mentioned this pull request Oct 12, 2023
Closed
4 tasks
@AdamLouly
Copy link
Contributor Author

Thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingyaHuang JingyaHuang JingyaHuang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdamLouly @JingyaHuang