ROS 2 dockerized example for nmea GPS #3
Conversation
…on and date standard Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Dockerfile
Outdated
|
|
||
| ## =========================== ROS builder =============================== |
There was a problem hiding this comment.
[major]
What's the purpose of having a separate entity building the package? The same packages are installed in both stages (i.e., ros-dev-tools), and rosdep is called twice with the same dependencies. In my opinion, this only complicates and unnecessarily prolongs the build process. I suggest installing and building everything sequentially in a single RUN command.
There was a problem hiding this comment.
There are some differences between ros-core and ros-base image but I can try to move this to one stage.
Dockerfile
Outdated
| rm -rf /etc/ros/rosdep/sources.list.d/20-default.list && \ | ||
| rosdep init && \ |
There was a problem hiding this comment.
Is it really necessary? If certain dependencies are already included in the husarnet/ros image, I believe they should be installed directly. Moreover, could you elaborate on the advantages and disadvantages of using this particular image? What rationale led us to choose it for this relatively straightforward use case over the basic ros docker image?
There was a problem hiding this comment.
Removing the sources is not necessary but rosdep has to be initialized other way it gives:
Dockerfile
Outdated
| apt-get clean && \ | ||
| rm -rf src && \ |
There was a problem hiding this comment.
I understand the importance of minimizing the image size, but in my opinion, this step may not be necessary. What do you think?
There was a problem hiding this comment.
I think it is good practice to reduce the image size as much as possible. In this case removing src does not impact a lot but e. g. when mesh files exists it changes a lot.
README.md
Outdated
| <h1 align="center"> | ||
| Docker Images for a GPS module | ||
| </h1> |
There was a problem hiding this comment.
| <h1 align="center"> | |
| Docker Images for a GPS module | |
| </h1> | |
| # Docker Images for a GPS module |
Alternatively, even the # nmea-gps-docker
README.md
Outdated
| The repository includes a GitHub Actions workflow that automatically deploys built Docker images to the [husarion/nmea-gps-docker](https://hub.docker.com/r/husarion/nmea-gps) Docker Hub repositories. This process is based on the [ros-drivers/nmea_navsat_driver](https://github.com/ros-drivers/nmea_navsat_driver/tree/ros2) repository. | ||
|
|
||
| [](https://github.com/husarion/nmea-gps-docker/actions/workflows/build-docker-image.yaml) | ||
| ### GPS API |
| required: true | ||
| default: 'main' | ||
|
|
||
| default: development |
There was a problem hiding this comment.
By the way, is it still in development or stable? I think we should aim to stabilize it and move away from reliance on this image. Are there plans to release tag v1.0.0 or something similar?
There was a problem hiding this comment.
In the docker repositories we added the development and the release build. Here are the options:
The purpose is to push images with date and package version.
After the PR is closed we can trigger the release build to make sure that image is tested and does work.
It adds to existing image e. g. humble-2.0.1-20240209 -stable to the tag what gives humble-2.0.1-20240209-stable.
Referring to the version. The tag of images are versions of the built package described in package.xml and the date of docker image build.
There was a problem hiding this comment.
I apologize for the misunderstanding. I've used this feature before, but I was referring to the GitHub tag.
There was a problem hiding this comment.
okay! So after the PR I can release this!
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Signed-off-by: Jakub Delicat <[email protected]>
Created ros2 workflow with standard date and package version tag.
Moved
compose.yamltodemo/folder.