Adding MySQL Support #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding $BAMBOO_DIR to MySQL Connector Installer Checking for $MYSQL_CONNECTOR_VERSION Environment Variable and set default value if it doesn't exist.
|
Good work on the pull request, I require these same changes for our setup and the latest versions of Bamboo require Java 1.8 |
| echo "Add MySQL" | ||
| MYSQL_CONNECTOR_VERSION="5.1.38" | ||
| wget http://dev.mysql.com/get/Downloads/Connector-J/mysql-connector-java-$MYSQL_CONNECTOR_VERSION.tar.gz -O /tmp/mysql-connector.tar.gz | ||
| tar xzf /tmp/mysql-connector.tar.gz -C /tmp |
There was a problem hiding this comment.
Extracting into /tmp is poor practice, I'd recommend creating a temporary directory (MYSQL_TMP_DIR=mktemp -d) and extracting into that. It has benefits, as shown in my next comment...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I think this is very useful, because if we want to use Bamboo for production needing a mysql database. So it's nice to have the necessary mysql connector already installed. (It's just +1MB)