-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MySQL Support #18
Open
smyth64
wants to merge
5
commits into
hwuethrich:master
Choose a base branch
from
schmidigital:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,7 @@ MAINTAINER H. Wüthrich "[email protected]" | |
CMD ["/sbin/my_init"] | ||
|
||
# Environment | ||
ENV BAMBOO_VERSION 5.7.2 | ||
ENV BAMBOO_VERSION 5.10.1.1 | ||
ENV BAMBOO_HOME /home/bamboo | ||
|
||
# Expose web and agent ports | ||
|
@@ -24,8 +24,8 @@ RUN apt-get update && apt-get upgrade -y # 28.01.2015 | |
|
||
# Install Java OpenJDK 7 and VCS tools | ||
RUN apt-get install -yq python-software-properties && add-apt-repository ppa:webupd8team/java -y && apt-get update | ||
RUN echo oracle-java7-installer shared/accepted-oracle-license-v1-1 select true | /usr/bin/debconf-set-selections | ||
RUN apt-get install -yq oracle-java7-installer git subversion | ||
RUN echo oracle-java8-installer shared/accepted-oracle-license-v1-1 select true | /usr/bin/debconf-set-selections | ||
RUN apt-get install -yq oracle-java8-installer git subversion | ||
|
||
# Clean up APT when done. | ||
RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,20 @@ else | |
echo "-> Extracting to $BAMBOO_DIR ..." | ||
tar xzf /tmp/atlassian-bamboo.tar.gz -C /opt | ||
rm -f /tmp/atlassian-bamboo.tar.gz | ||
|
||
|
||
echo "Add MySQL Connector" | ||
|
||
if [ -z $MYSQL_CONNECTOR_VERSION ]; then | ||
echo "MYSQL_CONNECTOR_VERSION not set. Setting to 5.1.38" | ||
MYSQL_CONNECTOR_VERSION=5.1.38 | ||
fi | ||
|
||
wget http://dev.mysql.com/get/Downloads/Connector-J/mysql-connector-java-$MYSQL_CONNECTOR_VERSION.tar.gz -O /tmp/mysql-connector.tar.gz | ||
tar xzf /tmp/mysql-connector.tar.gz -C /tmp | ||
mv /tmp/mysql-connector-java-$MYSQL_CONNECTOR_VERSION/mysql-connector-java-$MYSQL_CONNECTOR_VERSION-bin.jar $BAMBOO_DIR/lib/ | ||
rm -Rf /tmp/* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is too greedy and may have unintended side effects. It can be avoided with a wrapping temporary directory. |
||
|
||
echo "-> Installation completed" | ||
fi | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracting into /tmp is poor practice, I'd recommend creating a temporary directory (MYSQL_TMP_DIR=
mktemp -d
) and extracting into that. It has benefits, as shown in my next comment...