Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node to v20.x #1235

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

sapiderman
Copy link
Contributor

@sapiderman sapiderman commented Feb 5, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Implements Update to Node 20 #1234
  2. Updating node to v20.x

How did you implement / how did you fix it

  1. Update all pipelines
  2. Regenerate package.json

How to test

  1. Pushing the branch here first to test the pipelines. All pipelines should be green
  2. npm run test should all work without errors

Screenshot

image
(updated screenshot)

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (040c741) 63.47% compared to head (1910672) 63.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1235   +/-   ##
=======================================
  Coverage   63.47%   63.47%           
=======================================
  Files         111      111           
  Lines        3302     3302           
  Branches      568      568           
=======================================
  Hits         2096     2096           
  Misses       1016     1016           
  Partials      190      190           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little request changes.

package.json Show resolved Hide resolved
Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

@sapiderman sapiderman merged commit d96b3e1 into hyperjumptech:main Feb 12, 2024
6 checks passed
@sapiderman sapiderman deleted the feat/1234-update-node-20 branch February 12, 2024 07:39
@syamsudotdev syamsudotdev mentioned this pull request Feb 16, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants