Skip to content

Commit

Permalink
build(docs/examples): add yarn patch to @Ionic deps of example frontend
Browse files Browse the repository at this point in the history
1. The `main` field of the package.json of these two packages were invalid
because the `main` field was set to `bundle.js` but that file is actually
under `ngx/bundle.js` within the package directory and therefore the value
of it originally was invalid that caused warnings in our tooling.
2. By using the yarn **patch** feature we overcame this problem by modifying
the sources of the dependencies in question: `@ionic-native/splash-screen` and
`@ionic-native/status-bar`

Signed-off-by: Peter Somogyvari <[email protected]>
  • Loading branch information
petermetz committed Jul 6, 2024
1 parent 315e345 commit f492a3b
Show file tree
Hide file tree
Showing 6 changed files with 873 additions and 545 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
diff --git a/package.json b/package.json
index 93048af66b6ae275006be0eb70a0d06ee606b67f..3d4d2ff657475a98f16ed23778e33e09f78d850a 100644
--- a/package.json
+++ b/package.json
@@ -1 +1 @@
-{"description":"Ionic Native - Native plugins for ionic apps","main":"bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/splash-screen","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"}
+{"description":"Ionic Native - Native plugins for ionic apps","main":"ngx/bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/splash-screen","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
diff --git a/package.json b/package.json
index 2f7070b3e70fd5b9e013e3a707b589bad7f984f1..bc0094f00ef993e32e1b4a79fbb894d4780f0b92 100644
--- a/package.json
+++ b/package.json
@@ -1 +1 @@
-{"description":"Ionic Native - Native plugins for ionic apps","main":"bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/status-bar","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"}
+{"description":"Ionic Native - Native plugins for ionic apps","main":"ngx/bundle.js","module":"index.js","typings":"index.d.ts","author":"ionic","license":"MIT","repository":{"type":"git","url":"https://github.com/ionic-team/ionic-native.git"},"name":"@ionic-native/status-bar","dependencies":{"@types/cordova":"latest"},"peerDependencies":{"rxjs":"^5.5.0 || ^6.5.0","@ionic-native/core":"^5.1.0"},"version":"5.36.0"}
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@
"@hyperledger/cactus-plugin-ledger-connector-besu": "2.0.0-rc.2",
"@hyperledger/cactus-plugin-ledger-connector-fabric": "2.0.0-rc.2",
"@ionic-native/core": "5.36.0",
"@ionic-native/splash-screen": "5.36.0",
"@ionic-native/status-bar": "5.36.0",
"@ionic-native/splash-screen": "patch:@ionic-native/splash-screen@npm%3A5.36.0#~/.yarn/patches/@ionic-native-splash-screen-npm-5.36.0-531cbbe0f8.patch",
"@ionic-native/status-bar": "patch:@ionic-native/status-bar@npm%3A5.36.0#~/.yarn/patches/@ionic-native-status-bar-npm-5.36.0-1ca86cbaad.patch",
"@ionic/angular": "7.3.3",
"browserify-fs": "1.0.0",
"net-browserify": "0.2.4",
Expand Down
4 changes: 2 additions & 2 deletions examples/cactus-example-supply-chain-frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,8 @@
"@hyperledger/cactus-plugin-ledger-connector-fabric": "2.0.0-rc.2",
"@hyperledger/cactus-plugin-ledger-connector-quorum": "2.0.0-rc.2",
"@ionic-native/core": "5.36.0",
"@ionic-native/splash-screen": "5.36.0",
"@ionic-native/status-bar": "5.36.0",
"@ionic-native/splash-screen": "patch:@ionic-native/splash-screen@npm%3A5.36.0#~/.yarn/patches/@ionic-native-splash-screen-npm-5.36.0-531cbbe0f8.patch",
"@ionic-native/status-bar": "patch:@ionic-native/status-bar@npm%3A5.36.0#~/.yarn/patches/@ionic-native-status-bar-npm-5.36.0-1ca86cbaad.patch",
"@ionic/angular": "7.3.3",
"net-browserify": "0.2.4",
"run-time-error": "1.4.0",
Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,12 @@
"@commitlint/config-conventional": "17.7.0",
"@connectrpc/connect": "1.4.0",
"@connectrpc/protoc-gen-connect-es": "1.4.0",
"@lerna-lite/cli": "3.1.0",
"@lerna-lite/exec": "3.1.0",
"@lerna-lite/list": "3.1.0",
"@lerna-lite/publish": "3.1.0",
"@lerna-lite/run": "3.1.0",
"@lerna-lite/version": "3.1.0",
"@lerna-lite/cli": "3.7.0",
"@lerna-lite/exec": "3.7.0",
"@lerna-lite/list": "3.7.0",
"@lerna-lite/publish": "3.7.0",
"@lerna-lite/run": "3.7.0",
"@lerna-lite/version": "3.7.0",
"@openapitools/openapi-generator-cli": "2.7.0",
"@redocly/openapi-core": "1.15.0",
"@types/adm-zip": "0.5.0",
Expand Down
Loading

0 comments on commit f492a3b

Please sign in to comment.