Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ledger-connector-fabric): upgrade to compatible with Validator implementation #302

Closed
sfuji822 opened this issue Oct 6, 2020 · 3 comments · Fixed by #2645
Closed

refactor(ledger-connector-fabric): upgrade to compatible with Validator implementation #302

sfuji822 opened this issue Oct 6, 2020 · 3 comments · Fixed by #2645
Labels
Core_API Changes related to the Core API Package Developer_Experience enhancement New feature or request Fabric P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Milestone
v2.0.0

Comments

@sfuji822
Copy link
Contributor

sfuji822 commented Oct 6, 2020

Is your feature request related to a problem? Please describe.
Validators should have a common feature set to be part of the Ledger Plugin. PR#278 did not meet all functionality required for Validator. Still, the CACTUS core developer agreed on passing through it instead of rejecting the PR by adding a new issue item to remind fixing the identified issue.

Describe the solution you'd like
Fulfill missing functionalities such as sending signed-transaction(s), and refactoring to aligned to the Validator API in the white paper.
@sfuji822 sfuji822 added the enhancement New feature or request label Oct 6, 2020
@petermetz petermetz changed the title refacto(ledger-connector-fabric): upgrade to compatible with Validator implementation refactor(ledger-connector-fabric): upgrade to compatible with Validator implementation Oct 8, 2020
@petermetz petermetz added this to the v0.3.0 milestone Oct 8, 2020
This was referenced Nov 16, 2020
Merged
Merged
@takeutak takeutak mentioned this issue Dec 7, 2020
Merged
This was referenced Dec 18, 2020
Merged
Merged
@petermetz petermetz modified the milestones: v0.3.0, v0.4.0 Jan 8, 2021
@petermetz petermetz added Fabric Core_API Changes related to the Core API Package Developer_Experience Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. labels Feb 9, 2021
@petermetz petermetz modified the milestones: v0.4.0, v0.5.0 Apr 29, 2021
@petermetz petermetz modified the milestones: v0.5.0, v0.6.0 May 19, 2021
@RafaelAPB
Copy link
Contributor

Does this issue imply only adding things to the connector or removing it as well?
The Fabric connector is providing support for several business logic plugins - which could mean that those would need to be refactored as well

@petermetz petermetz modified the milestones: v0.6.0, v0.7.0 Jul 20, 2021
@petermetz petermetz modified the milestones: v0.7.0, v0.8.0 Aug 10, 2021
@petermetz petermetz modified the milestones: v0.8.0, v0.9.0 Aug 17, 2021
@petermetz petermetz modified the milestones: v0.9.0, v0.10.0 Sep 2, 2021
@petermetz petermetz added the P1 Priority 1: Highest label Aug 20, 2023
@petermetz petermetz modified the milestones: v0.10.0, v2.0.0 Aug 20, 2023
@petermetz
Copy link
Contributor

@sfuji822 I think this has been achieved in the meantime, but I'm not a 100% sure. Could you please confirm if we can close it or if it's still work in progress?

cc: @takeutak @izuru0 @outSH

@outSH outSH mentioned this issue Sep 11, 2023
Merged
@outSH
Copy link
Contributor

outSH commented Sep 11, 2023

@petermetz Can be closed once https://github.com/hyperledger/cacti/pull/2645 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Core_API Changes related to the Core API Package Developer_Experience enhancement New feature or request Fabric P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

feat(cactus-plugin-ledger-connector-fabric-socketio): remove fabric-socketio connector outSH/cactus
4 participants
@petermetz @outSH @RafaelAPB @sfuji822