docs: add Pull Request Template #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruzell22
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
requested changes
Sep 21, 2023
There was a problem hiding this comment.
@ruzell22 Please also convert the items (the paragraphs) that you have as a checklist into a literal checklist where people need to tick the boxes acknowledging that they have read the steps required (and also completed them)
ruzell22
force-pushed
the
prtemplate91
branch
from
cc5d2db to
b3de4d2
Compare
jagpreetsinghsasan
previously requested changes
Sep 26, 2023
There was a problem hiding this comment.
@ruzell22 can you convert these into something like
[ ] Rebased onto ...
[ ] Have git sign off
These get rendered as boxes which one can tick off in markdown
ruzell22
force-pushed
the
prtemplate91
branch
from
b3de4d2 to
5572da3
Compare
@jagpreetsinghsasan changes has been made and is repushed. Thank you |
|
LGTM, thankyou |
petermetz
approved these changes
Oct 2, 2023
petermetz
requested changes
Oct 2, 2023
There was a problem hiding this comment.
@ruzell22 Please sync the PR title and the commit subject line to the issue title.
The way this is right now, it would litter the release notes with this commit acting like a production code bug-fix (because of the fix commit type)
ruzell22
changed the title
|
@petermetz , synced the PR title and commit subject. Thank you |
petermetz
approved these changes
Oct 3, 2023
fixes: hyperledger-cacti#91 adds Pull Request Template on the root directory as guideline for contributors. Signed-off-by: ruzell22 <[email protected]>
petermetz
force-pushed
the
prtemplate91
branch
from
3ee4d86 to
567add9
Compare
petermetz
dismissed
jagpreetsinghsasan’s stale review
Changes were made according to the request.
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 12, 2023
fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 checkbox is updated so it will reflect as expected. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 12, 2023
fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 checkbox is updated so it will reflect as expected. Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 12, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 13, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 13, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]>
ruzell22
added a commit
to ruzell22/cactus
that referenced
this pull request
Oct 13, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]> [skip ci]
petermetz
pushed a commit
to ruzell22/cactus
that referenced
this pull request
Oct 18, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]> [skip ci]
petermetz
pushed a commit
that referenced
this pull request
Oct 18, 2023
Checkbox is updated so it will reflect as expected. fixes: #91 related to: #2708 Signed-off-by: ruzell22 <[email protected]> [skip ci]
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]> [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #91
adds Pull Request Template on the root directory as guideline for contributors.
[skip ci]