-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-plugin-ledger-connector-sawtooth): add new connector plugin #2825
Merged
petermetz
merged 1 commit into
hyperledger-cacti:main
from
outSH:sawtooth_openapi_connector_pr
Nov 2, 2023
Merged
feat(cactus-plugin-ledger-connector-sawtooth): add new connector plugin #2825
petermetz
merged 1 commit into
hyperledger-cacti:main
from
outSH:sawtooth_openapi_connector_pr
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
October 23, 2023 11:07
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Oct 23, 2023
…nector - Refactor discounted asset trade sample to use openapi sawtooth connector instead of sawtooth-socketio. - Remove sawtooth-socketio connector since it's not used any more. Depends on: hyperledger-cacti#2825 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
petermetz
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH LGTM!
izuru0
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Add new plugin for connecting with sawtooth ledgers. - New connector is based on already existing sawtooth-socketio connector. - Currently it supports only watchBlock and connector status endpoints. - Add new connector to cactus-verifier-client - Add integration tests in `cactus-test-plugin-ledger-connector-sawtooth`. Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
sawtooth_openapi_connector_pr
branch
from
November 2, 2023 23:25
7ddd2cc
to
65e4715
Compare
petermetz
pushed a commit
to outSH/cactus
that referenced
this pull request
Nov 3, 2023
…nector - Refactor discounted asset trade sample to use openapi sawtooth connector instead of sawtooth-socketio. - Remove sawtooth-socketio connector since it's not used any more. Depends on: hyperledger-cacti#2825 Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
Nov 3, 2023
…nector - Refactor discounted asset trade sample to use openapi sawtooth connector instead of sawtooth-socketio. - Remove sawtooth-socketio connector since it's not used any more. Depends on: #2825 Signed-off-by: Michal Bajer <[email protected]>
sandeepnRES
pushed a commit
to sandeepnRES/cacti
that referenced
this pull request
Dec 21, 2023
…nector - Refactor discounted asset trade sample to use openapi sawtooth connector instead of sawtooth-socketio. - Remove sawtooth-socketio connector since it's not used any more. Depends on: hyperledger-cacti#2825 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cactus-test-plugin-ledger-connector-sawtooth
.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.