Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-plugin-ledger-connector-aries): add new connector plugin #2947

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Dec 11, 2023

  • Add new plugin for connecting with aries agents and indy ledger.
  • Currently it supports only connecting to other aries agents and verifying
    proofs.
  • Add integration tests in cactus-test-plugin-ledger-connector-aries.
  • Update cactus-example-discounted-asset-trade to use the connector instead
    of plain aries agent.

Depends on #2946

Closes #1950

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM, thank you very much!

outSH added a commit to outSH/cactus that referenced this pull request Dec 12, 2023
- Remove old python connector cactus_validator_socketio_indy. It's been
    replaced with socketio-based cactus-plugin-ledger-connector-aries.
Depends on hyperledger-cacti#2947

Signed-off-by: Michal Bajer <[email protected]>
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@outSH
Copy link
Contributor Author

outSH commented Jan 19, 2024

TODO before merge - upgrade axios (https://github.com/hyperledger/cacti/pull/2986)

Copy link

This PR/issue depends on:

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Please resolve the merge conflicts and throw it back for a re-review!

@outSH outSH force-pushed the add_aries_connector_pr branch from 9dd3750 to e29cbff Compare January 22, 2024 12:49
@outSH outSH requested a review from petermetz January 22, 2024 12:50
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Thank you very much! Looks good in terms of the big picture, but of course as usual I had a bunch of smaller requests, suggestions and nit picks. Let me know if I can help with any of it!

@outSH outSH force-pushed the add_aries_connector_pr branch from e29cbff to 3f46946 Compare January 23, 2024 10:24
@outSH outSH requested a review from petermetz January 23, 2024 10:29
@outSH outSH force-pushed the add_aries_connector_pr branch from 3f46946 to 017084f Compare January 23, 2024 15:15
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Thank you for the updates! LGTM

- Add new plugin for connecting with aries agents and indy ledger.
- Currently it supports only connecting to other aries agents and verifying
    proofs.
- Add integration tests in `cactus-test-plugin-ledger-connector-aries`.
- Update `cactus-example-discounted-asset-trade` to use the connector instead
    of plain aries agent.

Depends on hyperledger-cacti#2946

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the add_aries_connector_pr branch from 017084f to c7efab2 Compare January 26, 2024 01:00
@petermetz petermetz enabled auto-merge (rebase) January 26, 2024 01:00
@petermetz petermetz merged commit afef5ae into hyperledger-cacti:main Jan 26, 2024
129 of 147 checks passed
outSH added a commit to outSH/cactus that referenced this pull request Jan 29, 2024
- Remove old python connector cactus_validator_socketio_indy. It's been
    replaced with socketio-based cactus-plugin-ledger-connector-aries.
Depends on hyperledger-cacti#2947

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit that referenced this pull request Jan 29, 2024
- Remove old python connector cactus_validator_socketio_indy. It's been
    replaced with socketio-based cactus-plugin-ledger-connector-aries.
Depends on #2947

Signed-off-by: Michal Bajer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(connector-indy): add indy plugin implementation
3 participants