-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-plugin-ledger-connector-aries): add new connector plugin #2947
feat(cactus-plugin-ledger-connector-aries): add new connector plugin #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH LGTM, thank you very much!
- Remove old python connector cactus_validator_socketio_indy. It's been replaced with socketio-based cactus-plugin-ledger-connector-aries. Depends on hyperledger-cacti#2947 Signed-off-by: Michal Bajer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TODO before merge - upgrade axios (https://github.com/hyperledger/cacti/pull/2986) |
This PR/issue depends on:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Please resolve the merge conflicts and throw it back for a re-review!
9dd3750
to
e29cbff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Thank you very much! Looks good in terms of the big picture, but of course as usual I had a bunch of smaller requests, suggestions and nit picks. Let me know if I can help with any of it!
packages/cactus-plugin-ledger-connector-aries/src/main/typescript/index.web.ts
Outdated
Show resolved
Hide resolved
...in-ledger-connector-aries/src/main/typescript/generated/openapi/typescript-axios/git_push.sh
Outdated
Show resolved
Hide resolved
packages/cactus-plugin-ledger-connector-aries/openapitools.json
Outdated
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-aries/src/main/typescript/api-client/aries-api-client.ts
Outdated
Show resolved
Hide resolved
e29cbff
to
3f46946
Compare
3f46946
to
017084f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH Thank you for the updates! LGTM
- Add new plugin for connecting with aries agents and indy ledger. - Currently it supports only connecting to other aries agents and verifying proofs. - Add integration tests in `cactus-test-plugin-ledger-connector-aries`. - Update `cactus-example-discounted-asset-trade` to use the connector instead of plain aries agent. Depends on hyperledger-cacti#2946 Signed-off-by: Michal Bajer <[email protected]>
017084f
to
c7efab2
Compare
- Remove old python connector cactus_validator_socketio_indy. It's been replaced with socketio-based cactus-plugin-ledger-connector-aries. Depends on hyperledger-cacti#2947 Signed-off-by: Michal Bajer <[email protected]>
- Remove old python connector cactus_validator_socketio_indy. It's been replaced with socketio-based cactus-plugin-ledger-connector-aries. Depends on #2947 Signed-off-by: Michal Bajer <[email protected]>
proofs.
cactus-test-plugin-ledger-connector-aries
.cactus-example-discounted-asset-trade
to use the connector insteadof plain aries agent.
Depends on #2946
Closes #1950
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.