-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weaver): add build script and fix minor issues #2971
feat(weaver): add build script and fix minor issues #2971
Conversation
Hello @VRamakrishna @sandeepnRES, please review :) More context on changes: ad
ad
|
- Upgrade typescript to 5.3.3 - Fix minor compilation issues where problems occurred. Closes hyperledger-cacti#2700 Depends on hyperledger-cacti#2971 Signed-off-by: Michal Bajer <[email protected]>
Thanks @outSH for the PR. Looks good to me just one thing you missed all the go packages (except one protos-go is there), not sure if it was intentional. Otherwise the PR looks good to me, given that CI tests are passing even after that package-local.json tests. So if you can confirm about go packages, I can approve the PR. And to correct the |
@sandeepnRES Well, at first I wanted to just build basic scenarios, and then I wanted to make it into build script and I've forgot about go sdk (to be precise, you mean
It seem to be caused by update of go-sdk dependencies in https://github.com/hyperledger/cacti/pull/2901. After |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outSH I like this a lot personally, but also I'll defer to @VRamakrishna and @sandeepnRES for final approval just to be sure they are OK with it too!
Ah okay, I'll approve this PR, we can do that in another PR, I'll look into this why this is happening, ideally it should not |
8a63530
to
19bb0a1
Compare
19bb0a1
to
8cfd6db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Add a bash script in tools to build all the weaver packages in single command. - Export `getMSPConfigurations` from fabric interop sdk (is imported in fabric cli, was causing compilation error on node 20) - Move bash shebang to the top of `check-nodes-status`. On ubuntu 20 having this below was causing the file to be interpreted as sh (resulting in error) - Update `package-local.json` files to be more inline with `package.json`. Signed-off-by: Michal Bajer <[email protected]>
8cfd6db
to
5e1b7dd
Compare
- Upgrade typescript to 5.3.3 - Fix minor compilation issues where problems occurred. Closes hyperledger-cacti#2700 Depends on hyperledger-cacti#2971 Signed-off-by: Michal Bajer <[email protected]>
- Upgrade typescript to 5.3.3 - Fix minor compilation issues where problems occurred. - Upgraded the protoc-gen-ts package to 0.8.7 which supports typescript 5.x whereas the previously used version only supported typescript 4.9 or earlier. This was causing the yarn codegen script to fail (the code generator script) Update from Peter: Bumped up protoc-gen-ts to latest versionl. Closes hyperledger-cacti#2700 Depends on hyperledger-cacti#2971 Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
- Upgrade typescript to 5.3.3 - Fix minor compilation issues where problems occurred. - Upgraded the protoc-gen-ts package to 0.8.7 which supports typescript 5.x whereas the previously used version only supported typescript 4.9 or earlier. This was causing the yarn codegen script to fail (the code generator script) Update from Peter: Bumped up protoc-gen-ts to latest versionl. Closes #2700 Depends on #2971 Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
getMSPConfigurations
from fabric interop sdk (is imported in fabric cli, was causing compilation error on node 20)check-nodes-status
. On ubuntu 20 having this below was causing the file to be interpreted as sh (resulting in error)package-local.json
files to be more inline withpackage.json
.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.