Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(rust-compiler): retire the container image and the test cases #3072

Conversation

petermetz
Copy link
Contributor

  1. This started off with me trying to fix the CVEs in the rust-compiler image.
  2. I was able to get rid of most of them by changing the base image to ubuntu-24.04
  3. The remaining high and critical ones were due to wasm-pack so went to see
    if we could upgrade that but we are already on the latest which is 8 months old.
    The vulnerabilities were reported on the wasm-pack repo 6 months ago along with
    a pull request that fixes them, neither the issue nor the pull request fixing it
    received any attention from the wasm-pack maintainers which lead me to believe
    that it is a liability to depend on it right now and we should instead look into
    a different tooling where the maintenance happens to have a little more resources
    dedicated to it. Java/Kotlin might be the way to go.
  4. I've also looked into possible alternatives to wasm-pack but the only
    other tool I found that does the same thing is cargo-web which hasn't had
    a new release for 4 years and counting and has even more CVEs plaguing it
    than wasm-pack.
  5. The official web assembly site links to wasm-pack when it comes to
    compiling to it from Rust so there's probably not a better maintained tool
    out there, but if someone finds something I'd love to start using it.
    In the meantime I'll just archive/retire/delete the rust compiler image
    and the tests associated with it because it's a maintenance burden that
    we don't need to carry.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. This started off with me trying to fix the CVEs in the rust-compiler image.
2. I was able to get rid of most of them by changing the base image to ubuntu-24.04
3. The remaining high and critical ones were due to wasm-pack so went to see
if we could upgrade that but we are already on the latest which is 8 months old.
The vulnerabilities were reported on the wasm-pack repo 6 months ago along with
a pull request that fixes them, neither the issue nor the pull request fixing it
received any attention from the wasm-pack maintainers which lead me to believe
that it is a liability to depend on it right now and we should instead look into
a different tooling where the maintenance happens to have a little more resources
dedicated to it. Java/Kotlin might be the way to go.
4. I've also looked into possible alternatives to wasm-pack but the only
other tool I found that does the same thing is cargo-web which hasn't had
a new release for 4 years and counting and has even more CVEs plaguing it
than wasm-pack.
5. The official web assembly site links to wasm-pack when it comes to
compiling to it from Rust so there's probably not a better maintained tool
out there, but if someone finds something I'd love to start using it.
In the meantime I'll just archive/retire/delete the rust compiler image
and the tests associated with it because it's a maintenance burden that
we don't need to carry.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-retire-rust-compiler-container-image branch from fc314d3 to 52fc7e8 Compare March 12, 2024 07:10
@petermetz petermetz merged commit f3974d2 into hyperledger-cacti:main Mar 12, 2024
119 of 146 checks passed
@petermetz petermetz deleted the test-retire-rust-compiler-container-image branch March 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants