feat(persistence-fabric): rewrite the plugin

[outSH]

feat(persistence-fabric): rewrite the plugin

• Rewrite fabric persistence plugin to match persistence ethereum
  plugin method names and overall behavior.
• Change DB schema for persistence.
• Add tests and sample data to the new plugin. Add them to the project CI.

Depends on #3298

Signed-off-by: Michal Bajer [email protected]

Pull Request Requirements

• Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
• Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
• Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

• Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
• Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

[gitguardian]

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-	-	Generic Password	1fce960	packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabric-db-client.test.ts	View secret
-	-	Generic Password	1fce960	packages/cactus-plugin-persistence-fabric/src/test/typescript/integration/persistence-fabrc-postgresql-db-client.test.ts	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[petermetz]

@outSH:I had a couple of nits but LGTM in general.

Important note: I'm in the process of fixing the release management flow we have and it involves a change in the development workflow when dealing with openapi spec files. The short version is that after that PR gets merged you'll need to make your changes in the openapi.tpl.json file instead of the openapi.json file (they'll be right next to each other for convenience.

[outSH]

@outSH TODO before merge: Add openapi.tpl.json file

[petermetz]

@outSH LGTM with comments:

For the commit message, it is a refactor then I'd recommend a commit message like this (or similar)

refactor(plugin-persistence-fabric): bring names closer to ethereum pkg

Reasoning:

1. If there is no new feature being added then the refactor type is probably better describing what happened because the functionality remained the same things just got renamed/shifted around.
2. "rewrite the plugin" is something that could describe a lot other changes where you rewrote something in the plugin, so I'd try to make it slightly more specific by pulling some of the information from the commit message body up to the subject line as well.

Sorry for the annoying nit-picks as usual!

[outSH]

@outSH LGTM with comments:

For the commit message, it is a refactor then I'd recommend a commit message like this (or similar)

refactor(plugin-persistence-fabric): bring names closer to ethereum pkg

Reasoning:

1. If there is no new feature being added then the refactor type is probably better describing what happened because the functionality remained the same things just got renamed/shifted around.
2. "rewrite the plugin" is something that could describe a lot other changes where you rewrote something in the plugin, so I'd try to make it slightly more specific by pulling some of the information from the commit message body up to the subject line as well.

Sorry for the annoying nit-picks as usual!

@petermetz This is a complete do-over of the plugin, with completely different plugin behavior (that matches ethereum persistence plugin in case of error handling, detecting missing blocks, etc..). It's not just name rearrangement, for this reason I think the current title is descriptive enough.

[github-actions]

This PR/issue depends on:

• hyperledger/cacti#3298
  By Dependent Issues (🤖). Happy coding!

[izuru0]

LGTM