-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(weaver-fabric-examples): use docker compose v2 #3358
test(weaver-fabric-examples): use docker compose v2 #3358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenniferlianne LGTM, thank you very much for the contribution!
70f1ef7
to
6082460
Compare
@jenniferlianne I just triggered various CI actions that were not automatically run when you submitted the PR. If the tests pass, I'll approve this. But note that If you want to fix all in this PR, I'll make a list. |
@VRamakrishna Thanks. Could you please put this one through? I have another change pending which updates network.sh to use the Fabric versions specified in the makefile that I'd like to put in. Reading the contribution guide, I thought I would separate the small-ish change into two very small ones to make the intention clear. Not sure if this was a good choice. |
6082460
to
6561b07
Compare
@jenniferlianne Here is a list of other locations within the
In some locations, the |
Primary change: Updates the weaver files to use docker compose v2 syntax. docker-compose v1 will be dropped on the github runners in a few weeks. Signed-off-by: Jennifer Bell <[email protected]>
6561b07
to
e6c4842
Compare
Closing, will resubmit with broader changes as requested. |
Updates the weaver fabric example network.sh file to use docker compose v2 syntax. docker-compose
v1 will be dropped on the github runners in a few weeks. (ref: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md)
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.