-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(test-tooling): fix BesuTestLedger start cfg: publish all ports #3379
Merged
petermetz
merged 1 commit into
hyperledger-cacti:main
from
petermetz:test-tooling-besu-test-ledger-fix-publish-all-ports
Jul 8, 2024
Merged
test(test-tooling): fix BesuTestLedger start cfg: publish all ports #3379
petermetz
merged 1 commit into
hyperledger-cacti:main
from
petermetz:test-tooling-besu-test-ledger-fix-publish-all-ports
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 4, 2024
1. We are in the process of decomissioning the Quorum connector and this is a pre-requisite to that end. Depends on hyperledger-cacti#3379 > test(test-tooling): fix BesuTestLedger start cfg: publish all ports) Fixes hyperledger-cacti#3272 Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
outSH
approved these changes
Jul 5, 2024
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 6, 2024
1. We are in the process of decomissioning the Quorum connector and this is a pre-requisite to that end. Depends on hyperledger-cacti#3379 > test(test-tooling): fix BesuTestLedger start cfg: publish all ports) Fixes hyperledger-cacti#3272 Signed-off-by: Peter Somogyvari <[email protected]>
jagpreetsinghsasan
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this for a moment when I was telling Ashna about the AIOs. Didnt paid much attention as I was explaining the entire code flow,but yes, this was happening.
LGTM
1. Previously we specified the publish all ports flag of the Docker Engine incorrectly and this lead to the ports not actually being published on randomized ports. 2. This broke the supply chain app example when we tried to migrate it to use 2 separate besu test ledger instances in tandem because they were conflicting on the ports due to the lack of randomization. Signed-off-by: Peter Somogyvari <[email protected]>
0b67cbf
to
79dd200
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this is a pre-requisite to that end. Depends on hyperledger-cacti#3379 > test(test-tooling): fix BesuTestLedger start cfg: publish all ports) Fixes hyperledger-cacti#3272 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this is a pre-requisite to that end. Depends on hyperledger-cacti#3379 > test(test-tooling): fix BesuTestLedger start cfg: publish all ports) Fixes hyperledger-cacti#3272 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this pull request
Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this is a pre-requisite to that end. Depends on #3379 > test(test-tooling): fix BesuTestLedger start cfg: publish all ports) Fixes #3272 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incorrectly and this lead to the ports not actually being published on
randomized ports.
use 2 separate besu test ledger instances in tandem because they were
conflicting on the ports due to the lack of randomization.
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.