Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(test-tooling): fix BesuTestLedger start cfg: publish all ports #3379

Conversation

petermetz
Copy link
Contributor

  1. Previously we specified the publish all ports flag of the Docker Engine
    incorrectly and this lead to the ports not actually being published on
    randomized ports.
  2. This broke the supply chain app example when we tried to migrate it to
    use 2 separate besu test ledger instances in tandem because they were
    conflicting on the ports due to the lack of randomization.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz enabled auto-merge (rebase) July 4, 2024 02:31
petermetz added a commit to petermetz/cacti that referenced this pull request Jul 4, 2024
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger-cacti#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger-cacti#3272

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz requested a review from RafaelAPB July 4, 2024 17:16
petermetz added a commit to petermetz/cacti that referenced this pull request Jul 6, 2024
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger-cacti#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger-cacti#3272

Signed-off-by: Peter Somogyvari <[email protected]>
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this for a moment when I was telling Ashna about the AIOs. Didnt paid much attention as I was explaining the entire code flow,but yes, this was happening.
LGTM

1. Previously we specified the publish all ports flag of the Docker Engine
incorrectly and this lead to the ports not actually being published on
randomized ports.
2. This broke the supply chain app example when we tried to migrate it to
use 2 separate besu test ledger instances in tandem because they were
conflicting on the ports due to the lack of randomization.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-tooling-besu-test-ledger-fix-publish-all-ports branch from 0b67cbf to 79dd200 Compare July 8, 2024 16:21
@petermetz petermetz merged commit ad08788 into hyperledger-cacti:main Jul 8, 2024
123 of 150 checks passed
@petermetz petermetz deleted the test-tooling-besu-test-ledger-fix-publish-all-ports branch July 8, 2024 16:32
petermetz added a commit to petermetz/cacti that referenced this pull request Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger-cacti#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger-cacti#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit to petermetz/cacti that referenced this pull request Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on hyperledger-cacti#3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes hyperledger-cacti#3272

Signed-off-by: Peter Somogyvari <[email protected]>
petermetz added a commit that referenced this pull request Jul 8, 2024
1. We are in the process of decomissioning the Quorum connector and this
is a pre-requisite to that end.

Depends on #3379
> test(test-tooling): fix BesuTestLedger start cfg: publish all ports)

Fixes #3272

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants