-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cactus-core-api): add Ethereum ledger type #3638
Merged
petermetz
merged 1 commit into
hyperledger-cacti:main
from
RafaelAPB:satp-dev-fixup-cactus-core-api-ledger
Nov 30, 2024
Merged
feat(cactus-core-api): add Ethereum ledger type #3638
petermetz
merged 1 commit into
hyperledger-cacti:main
from
RafaelAPB:satp-dev-fixup-cactus-core-api-ledger
Nov 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafaelAPB
requested review from
petermetz,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
November 15, 2024 16:23
This was referenced Nov 15, 2024
petermetz
approved these changes
Nov 20, 2024
outSH
approved these changes
Nov 25, 2024
@RafaelAPB The build is failing, I'll take a quick look at it, see if I can fix it quickly before the 2.0.1 release goes out today. Error: packages/cacti-plugin-consortium-static/src/main/typescript/plugin-consortium-static.ts(469,7): error TS2322: Type 'import("/home/runner/work/cacti/cacti/packages/cactus-core-api/dist/lib/main/typescript/generated/openapi/typescript-axios/api").Ledger[]' is not assignable to type 'import("/home/runner/work/cacti/cacti/packages/cacti-plugin-consortium-static/src/main/typescript/generated/openapi/typescript-axios/api").Ledger[]'.
Type 'import("/home/runner/work/cacti/cacti/packages/cactus-core-api/dist/lib/main/typescript/generated/openapi/typescript-axios/api").Ledger' is not assignable to type 'import("/home/runner/work/cacti/cacti/packages/cacti-plugin-consortium-static/src/main/typescript/generated/openapi/typescript-axios/api").Ledger'.
Types of property ''ledgerType'' are incompatible.
Type 'import("/home/runner/work/cacti/cacti/packages/cactus-core-api/dist/lib/main/typescript/generated/openapi/typescript-axios/api").LedgerType' is not assignable to type 'import("/home/runner/work/cacti/cacti/packages/cacti-plugin-consortium-static/src/main/typescript/generated/openapi/typescript-axios/api").LedgerType'.
Type '"ETHEREUM"' is not assignable to type 'LedgerType'.
|
petermetz
force-pushed
the
satp-dev-fixup-cactus-core-api-ledger
branch
from
November 30, 2024 19:09
90aea43
to
1dd1f17
Compare
@RafaelAPB I pushed the fixes to the build, updating the PR description now too |
Oops, forgot about the linter errors, working on those now. |
Peter's change: Added the missing `ETHEREUM` constant to the leger type that the static consortium plugin has built in to it. This was necessary because adding it only to the core-api broke the build. The two types (since they are duplicates of each other) must be updated in tandem otherwise the code won't compile (which is a good thing because it is an example if when the compiler saves us from mistakes like this that would otherwise stay hidden until much later and only come out as runtime errors) Authored-by: Bruno Mateus Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Rafael Belchior <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
satp-dev-fixup-cactus-core-api-ledger
branch
from
November 30, 2024 19:37
1dd1f17
to
a855437
Compare
Linter fixes should be applied now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peter's change: Added the missing ETHEREUM constant to the leger type
that the static consortium plugin has built in to it.
This was necessary because adding it only to the core-api broke the build.
The two types (since they are duplicates of each other) must be updated in
tandem otherwise the code won't compile (which is a good thing because it
is an example if when the compiler saves us from mistakes like this that would
otherwise stay hidden until much later and only come out as runtime errors)
Authored-by: Bruno Mateus
Co-authored-by: Peter Somogyvari [email protected]
Signed-off-by: Rafael Belchior [email protected]
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.