Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add satp logging in all satges #3665

Conversation

Yogesh01000100
Copy link
Contributor

@Yogesh01000100 Yogesh01000100 commented Dec 2, 2024

Description

  • refactored gateway argument in storeLog & storeProof in gateway utils file.
  • modified interface BLODispatcherOptions & SATPGatewayConfi , so that we can add the database connections, also injecting the dependencies of repository to the SATPmanager so the respective services have a way to store the logs.
  • Improved SATP client and server stage services with databse logging.
  • Added a new logging file to centralize and simplify log operations. (logging.ts)
  • test on packages/cactus-plugin-satp-hermes/src/test/typescript/unit/services.test.ts

Addresses #3114

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@Yogesh01000100 Yogesh01000100 force-pushed the feature/satp-protocol-logging branch 2 times, most recently from 188a2d3 to 843383a Compare December 2, 2024 21:12
@Yogesh01000100 Yogesh01000100 force-pushed the feature/satp-protocol-logging branch from 843383a to 4c23272 Compare December 4, 2024 12:26
Copy link
Contributor

@LordKubaya LordKubaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yogesh01000100 Yogesh01000100 force-pushed the feature/satp-protocol-logging branch from 4c23272 to f5c8410 Compare December 4, 2024 15:08
Copy link
Contributor

@RafaelAPB RafaelAPB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with minor improvements. Please incorporate the feedback.
Please move store Log and other store functions to src/main/typescript/logging. Please create a SATPLogger class that has the persistLogEntry (previously storeLog) method, so they can be called in the respective services.

Please add all relevant log operations (many missing). Please define an interface for the log entries (input to satplogger.persistlogentry)

1. Improved SATP client and server stage services with databse logging.
2. Added a new logging file to centralize and simplify log operations.
3. Integrated Knex config into the Gateway.

Signed-off-by: Yogesh01000100 <[email protected]>
@Yogesh01000100 Yogesh01000100 force-pushed the feature/satp-protocol-logging branch from 39f22da to 0a6e563 Compare December 6, 2024 12:27
@RafaelAPB RafaelAPB merged commit 0f9fb71 into hyperledger-cacti:satp-dev Dec 6, 2024
9 of 10 checks passed
Yogesh01000100 added a commit to Yogesh01000100/cacti that referenced this pull request Dec 9, 2024
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig

Fixes hyperledger-cacti#3665

Signed-off-by: Yogesh01000100 <[email protected]>
Yogesh01000100 added a commit to Yogesh01000100/cacti that referenced this pull request Dec 10, 2024
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig

Fixes hyperledger-cacti#3665

Signed-off-by: Yogesh01000100 <[email protected]>
Yogesh01000100 added a commit to Yogesh01000100/cacti that referenced this pull request Dec 10, 2024
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig

Fixes hyperledger-cacti#3665

Signed-off-by: Yogesh01000100 <[email protected]>
RafaelAPB pushed a commit that referenced this pull request Dec 11, 2024
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig

Fixes #3665

Signed-off-by: Yogesh01000100 <[email protected]>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this pull request Dec 16, 2024
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig

Fixes hyperledger-cacti#3665

Signed-off-by: Yogesh01000100 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants