-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add satp logging in all satges #3665
feat: add satp logging in all satges #3665
Conversation
188a2d3
to
843383a
Compare
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Outdated
Show resolved
Hide resolved
843383a
to
4c23272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c23272
to
f5c8410
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM with minor improvements. Please incorporate the feedback.
Please move store Log and other store functions to src/main/typescript/logging. Please create a SATPLogger class that has the persistLogEntry (previously storeLog) method, so they can be called in the respective services.
Please add all relevant log operations (many missing). Please define an interface for the log entries (input to satplogger.persistlogentry)
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage0-client-service.ts
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage1-client-service.ts
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage1-client-service.ts
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage2-client-service.ts
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/client/stage3-client-service.ts
Outdated
Show resolved
Hide resolved
...s-plugin-satp-hermes/src/main/typescript/core/stage-services/server/stage0-server-service.ts
Outdated
Show resolved
Hide resolved
f5c8410
to
39f22da
Compare
1. Improved SATP client and server stage services with databse logging. 2. Added a new logging file to centralize and simplify log operations. 3. Integrated Knex config into the Gateway. Signed-off-by: Yogesh01000100 <[email protected]>
39f22da
to
0a6e563
Compare
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes hyperledger-cacti#3665 Signed-off-by: Yogesh01000100 <[email protected]>
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes hyperledger-cacti#3665 Signed-off-by: Yogesh01000100 <[email protected]>
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes hyperledger-cacti#3665 Signed-off-by: Yogesh01000100 <[email protected]>
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes #3665 Signed-off-by: Yogesh01000100 <[email protected]>
1.Integrated knexLocalConfig and knexRemoteConfig into SATPGatewayConfig Fixes hyperledger-cacti#3665 Signed-off-by: Yogesh01000100 <[email protected]>
Description
storeLog
&storeProof
in gateway utils file.SATPmanager
so the respective services have a way to store the logs.logging.ts
)packages/cactus-plugin-satp-hermes/src/test/typescript/unit/services.test.ts
Addresses #3114
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.