-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] #3889: prune docker-compose files #3969
[ci] #3889: prune docker-compose files #3969
Conversation
@0x009922 afaik initial reason for having multiple files was to prevent situation when new user is trying to run |
I guess we should first extend this PR with a new CI which will ensure the sync of the Dockerhub image used in the docker files, and the branch the file is located on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to integrate a CI check to validate Docker images. Something like this sketch may work.
The idea is to fail the CI process when we see a Docker configuration that will use the dev
image when it's being merged to the https://github.com/hyperledger/iroha/tree/iroha2-stable branch.
(I wonder if we can agree on a container name that'll always replace the dev image so the script will edit the Compose configurations instead of failing.)
66fec94
to
bf90a7d
Compare
Signed-off-by: Dmitry Balashov <[email protected]>
30f35aa
to
1cbee22
Compare
I'll remind you that the impetus for the original shift towards docker compose files for different branches on the same branch was because of community confusion, and problems caused by merging into If you remove them, please consider adding something instead that fixes those issues. I'd advise not doing this, because even a simple docker compose generator needs to be ran by the user and those will often not work. Pulling the |
Closing in favor of #4053. @appetrosyan, now we have a single set of docker-compose configuration files binded to the branch. The primary intention we have is to reduce any confusion of end users: they come to the repo on whatever branch they want, and they use instructions in the README of that branch, which are usually simply "use We have also introduced a CI check that ensures that compose files in We are also planning to add CI checks to ensure that docker compose files are not only valid textually, but that they are also actually runnable. |
Description
Currently each branch (
iroha2-<lts|stable|dev>
) has set of docker-compose files not only for itself, but for other branches too. It leads to confusion and goes against how versioning works. Moreover, since2.0
release will be relatively soon and we are going to get rid of channels at all, there is no sense to keep them in the dev branch.This PR removes docker-compose files related to other branches/channels, and removes
.dev
suffix from the configurations related todev
branch.Linked issue
Closes #3889 (will be completely closed after merging into
iroha2-stable
)Benefits
Less confusion, natural branch-based versioning and CI checks
Checklist