Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]: docker image validator #4053

Merged
merged 6 commits into from
Jan 26, 2024
Merged

[ci]: docker image validator #4053

merged 6 commits into from
Jan 26, 2024

Conversation

6r1d
Copy link
Contributor

@6r1d 6r1d commented Nov 13, 2023

Description

Adds a script for #3969: prune docker-compose.yml files

@6r1d 6r1d requested a review from 0x009922 November 13, 2023 23:08
@6r1d 6r1d self-assigned this Nov 13, 2023
@6r1d 6r1d marked this pull request as draft November 13, 2023 23:09
@6r1d 6r1d changed the base branch from main to iroha2-dev November 13, 2023 23:10
@6r1d 6r1d marked this pull request as ready for review November 13, 2023 23:11
@6r1d 6r1d added iroha2-dev The re-implementation of a BFT hyperledger in RUST CI labels Nov 13, 2023
@mversic mversic changed the title Ci/docker image validator [ci]: docker image validator Nov 14, 2023
@mversic mversic force-pushed the ci/docker_image_validator branch from a300620 to f059f02 Compare November 27, 2023 09:38
@coveralls
Copy link

coveralls commented Nov 27, 2023

Pull Request Test Coverage Report for Build 7043469764

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7014 unchanged lines in 129 files lost coverage.
  • Overall coverage decreased (-3.1%) to 56.307%

Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.1%
Covered Lines: 23025
Relevant Lines: 40892

💛 - Coveralls

@6r1d 6r1d force-pushed the ci/docker_image_validator branch 4 times, most recently from 93d3926 to fddd92a Compare January 23, 2024 07:37
@6r1d 6r1d force-pushed the ci/docker_image_validator branch from da3b354 to ef05a9c Compare January 23, 2024 09:30
0x009922
0x009922 previously approved these changes Jan 23, 2024
@0x009922
Copy link
Contributor

As you can see, you should also update consistency.sh.

@mversic mversic force-pushed the ci/docker_image_validator branch from 196c530 to 11fdf13 Compare January 25, 2024 14:46
@6r1d 6r1d enabled auto-merge (squash) January 26, 2024 10:24
@6r1d 6r1d merged commit 925b556 into iroha2-dev Jan 26, 2024
1 check passed
@6r1d 6r1d deleted the ci/docker_image_validator branch January 26, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants