Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include settle secondary #47

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

sophia1ch
Copy link
Contributor

This PR reverts the removal of secondary settling to reduce transaction fees.

…ing that uses the AdjudicatorReq object during conclusion of a channel. Also remove functions that are necessary for the Secondary option."

This reverts commit 1188366.

Signed-off-by: sophia <[email protected]>
@sophia1ch sophia1ch force-pushed the include-settle-secondary branch from 906b8e2 to e978fd9 Compare February 19, 2024 12:04
Signed-off-by: sophia1ch <[email protected]>
@sophia1ch sophia1ch marked this pull request as ready for review February 20, 2024 08:58
@iljabvh iljabvh self-requested a review February 20, 2024 15:14
Copy link
Contributor

@iljabvh iljabvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR reverts the changes that removed the option to wait for a peer to conclude the channel. It restores the ability to wait for a specified number of blocks until the channel peer has called concludeFinal.

@iljabvh iljabvh merged commit 44adf86 into hyperledger-labs:main Feb 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants