-
-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resize artifacts (stretching, bumps) #7499
Conversation
ready for review |
Um, I don't see a difference. |
well I surely do, mind to get a recording? |
Definitely can see the improvement. no-patch-foot-no-anim.mp4And with patch patch-foot-no-anim.mp4Notice no bg flash on the left window. |
Oh, that's the only thing I wasn't looking at. A lot of the other problems are still there though. |
It's because its 1.25 monitor scale, can't reproduce on 1 Foot on defaults (with my bindings and colors), and hyprland now with hdefault-min.conf.txt |
looks very nice. |
can't repro, what wallpaper daemon? |
hyprpaper, For more useful repro steps, it's a 4k wallpaper at 3440x1440 resolution @165hz for monitor config with 1.25 fractional scaling. |
Used it for a while, can't really tell the difference tbh. No noticeable problems have come up either. |
Can also see this effect #7499 (comment) with nested sway and cage Latest git aqua / hl |
I should revisit this mr some day |
😭 |
a073587
to
2264489
Compare
some fixes including for those stretched things, but if I launch two terminals quickly they kinda wonkily stretch still lmk if there are any other issues. I am also doubting a bit whether this is the best solution. I mean, what should we fill the gaps with? |
any1? |
I think even with animations this is a clear improvement. hyprland_old_stretchy_resize.mp4NEW: hyprland_new_resize.mp4Did not find any issues with it so far. |
Nested sway/cage issue is fixed. This #7499 (comment) still happens Details
scale 1.25, slowed down open-patch.mp4close-patch.mp4scale 1, normal speed scale-1-open-patch.mp4scale-1-close-patch.mp4 |
it's still better than main no? Lmk if there are any important bugs. The quick open bug is one that is annoying to me but I can live with it. Basically, open two kitty terminals in quick succession, the first one will kinda squeeze, which looks odd. @MahouShoujoMivutilde I am unsure why your one happens |
It's definitely better. I don't see any other bugs, nor do I see any problem with kitty. Details
kitty-quick.mp4 |
resizebug.mp4clearly visible here |
Oh, yeah, I see now. I just had my
so it wasn't visible to me. With Details
vertical-stretch.mp4 |
This comment was marked as outdated.
This comment was marked as outdated.
magic |
Most likely, xwayland crashed for me for the same reason #7936 happens. Idk what triggered it first two times, but it's unrelated to the patch. |
with @PaideiaDilemma's fix the resize bug is gone. Happy with merging this. Thanks everyone |
WIP
Fixes resize artifacts notably when using the mouse to resize apps to larger sizes (stretching etc)
ref #7475