Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resize artifacts (stretching, bumps) #7499

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Fix resize artifacts (stretching, bumps) #7499

merged 4 commits into from
Oct 4, 2024

Conversation

vaxerski
Copy link
Member

@vaxerski vaxerski commented Aug 24, 2024

WIP

Fixes resize artifacts notably when using the mouse to resize apps to larger sizes (stretching etc)

ref #7475

@vaxerski vaxerski marked this pull request as ready for review August 24, 2024 15:05
@vaxerski
Copy link
Member Author

ready for review

@diniamo
Copy link
Contributor

diniamo commented Aug 24, 2024

Um, I don't see a difference.

@vaxerski
Copy link
Member Author

well I surely do, mind to get a recording?

@MahouShoujoMivutilde
Copy link
Contributor

MahouShoujoMivutilde commented Aug 24, 2024

Definitely can see the improvement.

no-patch-foot-no-anim.mp4

And with patch

patch-foot-no-anim.mp4

Notice no bg flash on the left window.

@diniamo
Copy link
Contributor

diniamo commented Aug 25, 2024

Oh, that's the only thing I wasn't looking at. A lot of the other problems are still there though.

@vaxerski
Copy link
Member Author

image
this frame is odd, as the patch should expand the texture along the edges. What's that terminal and what settings?

@MahouShoujoMivutilde
Copy link
Contributor

It's because its 1.25 monitor scale, can't reproduce on 1

Foot on defaults (with my bindings and colors), and hyprland now with hdefault-min.conf.txt

@ferrreo
Copy link
Contributor

ferrreo commented Aug 25, 2024

This patch does this to my wallpaper at 1.25 scaling:
image

Other than that and not fixing Electron resizing artifacts it does seem to fix stretching etc overall when resizing other things.

@vaxerski
Copy link
Member Author

looks very nice.

@vaxerski
Copy link
Member Author

can't repro, what wallpaper daemon?

@ferrreo
Copy link
Contributor

ferrreo commented Aug 25, 2024

can't repro, what wallpaper daemon?

hyprpaper,

For more useful repro steps, it's a 4k wallpaper at 3440x1440 resolution @165hz for monitor config with 1.25 fractional scaling.

@Agent00Ming
Copy link
Contributor

Used it for a while, can't really tell the difference tbh. No noticeable problems have come up either.

@MahouShoujoMivutilde
Copy link
Contributor

Can also see this effect #7499 (comment) with nested sway and cage

With patch

27-09-2024-21_22_21

Without

27-09-2024-21_21_29

Latest git aqua / hl

@vaxerski
Copy link
Member Author

I should revisit this mr some day

@diniamo
Copy link
Contributor

diniamo commented Sep 27, 2024

some day

😭

@vaxerski
Copy link
Member Author

vaxerski commented Sep 28, 2024

some fixes including for those stretched things, but if I launch two terminals quickly they kinda wonkily stretch still

lmk if there are any other issues.

I am also doubting a bit whether this is the best solution. I mean, what should we fill the gaps with?

@vaxerski
Copy link
Member Author

any1?

@PaideiaDilemma
Copy link
Contributor

PaideiaDilemma commented Sep 29, 2024

I think even with animations this is a clear improvement.
Here is how it looks on my config.
OLD:

hyprland_old_stretchy_resize.mp4

NEW:

hyprland_new_resize.mp4

Did not find any issues with it so far.

@MahouShoujoMivutilde
Copy link
Contributor

Nested sway/cage issue is fixed.

This #7499 (comment) still happens

Details

scale 1.25, slowed down

open-patch.mp4
close-patch.mp4

scale 1, normal speed

scale-1-open-patch.mp4
scale-1-close-patch.mp4

@vaxerski
Copy link
Member Author

it's still better than main no? Lmk if there are any important bugs. The quick open bug is one that is annoying to me but I can live with it.

Basically, open two kitty terminals in quick succession, the first one will kinda squeeze, which looks odd.

@MahouShoujoMivutilde I am unsure why your one happens

@MahouShoujoMivutilde
Copy link
Contributor

It's definitely better. I don't see any other bugs, nor do I see any problem with kitty.

Details

kitty-quick.mp4

@vaxerski
Copy link
Member Author

resizebug.mp4

clearly visible here

@MahouShoujoMivutilde
Copy link
Contributor

Oh, yeah, I see now. I just had my

    bezier = cst, 0.84, 0.37, 0.2, 0.62
    animation = windows, 1, 7, cst
    animation = windowsMove, 1, 2, default
    animation = windowsOut, 1, 3, default, popin 80%

so it wasn't visible to me.

With animation = windows, 1, 7, cst, if I open another terminal during about midpoint of the opening animation of the first, this I can reproduce the similar effect, but in the form of a vertical stretching, for both kitty and foot.

Details

vertical-stretch.mp4

@MahouShoujoMivutilde

This comment was marked as outdated.

@vaxerski
Copy link
Member Author

magic

@MahouShoujoMivutilde
Copy link
Contributor

MahouShoujoMivutilde commented Sep 29, 2024

Most likely, xwayland crashed for me for the same reason #7936 happens.

Idk what triggered it first two times, but it's unrelated to the patch.

@vaxerski
Copy link
Member Author

vaxerski commented Oct 4, 2024

with @PaideiaDilemma's fix the resize bug is gone. Happy with merging this. Thanks everyone

@vaxerski vaxerski merged commit dd7e352 into main Oct 4, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants