-
-
Notifications
You must be signed in to change notification settings - Fork 6
[WIP] add session lock support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
Ok so just to keep track of things, here are the problems I encountered when trying to implement hyprlocks password input field.
|
There is an element prop for that it's just not exposed. I'm fine with exposing it (containsChildren clipChildren or something liek that)
Simple fix
Why not? You can add an event fd to the loop. See pwcenter it uses pw_loop's fd.
Yes, shaders have that feature already as I copied them from HL. Just needs an impl in the C++ part. I'd say get session lock to work in this MR, we'll merge it, then deal with those four issues in subsequent MRs. Is the lock part gtg? |
|
All of that sounds nice. Thanks! Lock part needed the denied event. Now I think it would be gtg. |
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
xoxo
983e755 to
1715e15
Compare
|
I will ping for next review :) |
|
alr |
Lock screens need to know when to exit without an unlock.
vaxerski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
| virtual uint32_t handle() = 0; | ||
| virtual std::string port() = 0; | ||
| virtual std::string desc() = 0; | ||
| virtual uint32_t fps() = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is fps a uint32_t? shouldn't this be a) refresh() and b) refresh... in what? mHz I assume if uint32_t?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh wait I forgot that.
I still wanted to ask you about this.
I only need that to make the animation manager tick in sync with the refresh rate.
Is that the way we should do that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, tick on a .frame and throttle to max fps (cases with multiple surfaces)
might wanna add that "tick()" to the wl callback in IWaylandWindow
|
|
||
| namespace Hyprtoolkit { | ||
| enum eSessionLockError : uint8_t { | ||
| PLATFORM_UNINTIALIZED, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOCK_ERROR_PLATFORM_UNINITIALIZED, etc.
This is a first proposal for session-lock in hyprtoolkit.
It is intended for hyprlock to be implemented on top of it.
This version here has almost everything that should be needed.
TODOS:
outputAdded)