-
-
Notifications
You must be signed in to change notification settings - Fork 6
[WIP] add session lock support #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PaideiaDilemma
wants to merge
17
commits into
hyprwm:main
Choose a base branch
from
PaideiaDilemma:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+744
−46
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
62442d8
add CWaylandOutput
PaideiaDilemma 25e2835
add WaylandLockSurface
PaideiaDilemma 4306f19
add CCExtSessionLockV1
PaideiaDilemma 308cf97
add IOutput
PaideiaDilemma b44e627
add better emit of outputAdded
PaideiaDilemma b039c6e
add m_lockSurfaces to windowForSurf to make click work
PaideiaDilemma 142c301
handle CCExtSessionLockV1 finished event
PaideiaDilemma 10b073e
add needed stuff to IOutput
PaideiaDilemma a570c91
remove CBackend::attempt
PaideiaDilemma a5ae1ed
add lockDenied event to the backend
PaideiaDilemma f9e3556
add IOutput->fps
PaideiaDilemma 6de96fa
add ISessionLockState and aquireSessionLock to CBackend
PaideiaDilemma 6d1f480
include fixups
PaideiaDilemma 0cfd03f
click to unlock in simple session lock
PaideiaDilemma 0222553
remove optional, construct WP nullptr from SP
PaideiaDilemma f1d85ad
fixups
PaideiaDilemma c76f4eb
fix rebase
PaideiaDilemma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| #pragma once | ||
|
|
||
| #include <hyprutils/signal/Signal.hpp> | ||
| #include <hyprutils/math/Vector2D.hpp> | ||
|
|
||
| namespace Hyprtoolkit { | ||
| class IOutput { | ||
| public: | ||
| virtual ~IOutput() = default; | ||
| virtual uint32_t handle() = 0; | ||
| virtual std::string port() = 0; | ||
| virtual std::string desc() = 0; | ||
| virtual uint32_t fps() = 0; | ||
|
|
||
| struct { | ||
| /* output removed */ | ||
| Hyprutils::Signal::CSignalT<> removed; | ||
| } m_events; | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #pragma once | ||
|
|
||
| #include <hyprutils/signal/Signal.hpp> | ||
| #include <hyprutils/math/Vector2D.hpp> | ||
|
|
||
| namespace Hyprtoolkit { | ||
| enum eSessionLockError : uint8_t { | ||
| PLATFORM_UNINTIALIZED, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. LOCK_ERROR_PLATFORM_UNINITIALIZED, etc. |
||
| DENIED, | ||
| }; | ||
|
|
||
| class ISessionLockState { | ||
| public: | ||
| virtual ~ISessionLockState() = default; | ||
| virtual void unlock() = 0; | ||
|
|
||
| struct { | ||
| /* signals that we don't need to unlock anymore. It makes sense to exit upon recieving this */ | ||
| Hyprutils::Signal::CSignalT<> finished; | ||
| } m_events; | ||
| }; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is fps a uint32_t? shouldn't this be a) refresh() and b) refresh... in what? mHz I assume if uint32_t?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh wait I forgot that.
I still wanted to ask you about this.
I only need that to make the animation manager tick in sync with the refresh rate.
Is that the way we should do that?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, tick on a .frame and throttle to max fps (cases with multiple surfaces)
might wanna add that "tick()" to the wl callback in IWaylandWindow