-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .iui-field
base class for inputs
#1919
Conversation
@mayank99 I continued working on this yesterday and I'm up to 22 files changed locally (haven't pushed yet), starting to be concerned that the scope has creeped too far:
|
I think it makes sense to keep the PRs separate, to make the review easier.
You can even chain one PR to the other one, by creating a branch on top of it and changing the base. (Read more: 1, 2) |
<button class='iui-button' data-iui-variant='borderless' aria-label='Close'> | ||
<svg-close-small class='iui-button-icon' aria-hidden='true'></svg-close-small> | ||
</button> | ||
<div class='iui-input-flex-container'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but fixes a broken test.
data-iui-variant='borderless' | ||
data-iui-size='small' | ||
data-iui-active='true' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but fixes a button issue.
Co-authored-by: Mayank <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I would maybe wait for another approval though, just to make sure nothing was missed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Just a few more comments of which some are nit/optional.
Co-authored-by: Rohan Kadkol <[email protected]>
Co-authored-by: Mayank <[email protected]>
Changes
.iui-field
class which gives base styling (background-color
,color
,border-color
,data-iui-variant
, etc) for many inputs (<button>
,<input>
,<textarea>
,<select>
). This reduces duplicate CSS and helps keep styling consistent.<input>
,<textarea>
,<select>
now have matching hover state with<button>
.<input>
,<textarea>
,<select>
text styling is different:Testing
Docs
After PR TODOs