Made expandable content a separate component #2240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smmr-dn
requested review from
mayank99 and
r100-stack
and removed request for
a team
mayank99
reviewed
Sep 12, 2024
packages/itwinui-react/src/core/Table/TableExpandableContentMemoized.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/core/Table/TableExpandableContentMemoized.tsx
Outdated
Show resolved
Hide resolved
packages/itwinui-react/src/core/Table/TableExpandableContentMemoized.tsx
Outdated
Show resolved
Hide resolved
…/iTwin/iTwinUI into uyen/separate-expandable-content
r100-stack
reviewed
Sep 13, 2024
packages/itwinui-react/src/core/Table/TableExpandableContentMemoized.tsx
Outdated
Show resolved
Hide resolved
r100-stack
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
LGTM after the visual test is fixed. But since this PR is a part of #2208, we shouldn't merge this right away. You can update #2208 to point to this PR's branch instead of main. More info about stacking PRs.
|
I'm good with merging it tbh. No reason to leave it hanging. It's a small, standalone PR that does exactly what it says. |
|
Then merging it sounds good too in this case. If we need to make any changes related the contents of this PR, we can then do it in #2208 itself or in another PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Separate expandable content in
Tableto another component, independent from the originalTableRowMemoized. This PR prepares for the fixing of the bug that is caused by sub-component not being recognized by the virtualizer when being rendered within the main row.Testing
Confirmed the expandable contents visually turned out correctly.
Docs
N/A
After-PR TODO: