Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made expandable content a separate component #2240

Merged
merged 15 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/itwinui-react/src/core/Table/Table.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ it('should render sub-rows and handle expansions', async () => {
expect(onExpand).toHaveBeenNthCalledWith(1, [data[0]], expect.any(Object));
expect(onExpand).toHaveBeenNthCalledWith(
2,
[data[0], data[1]],
[data[0], data[0].subRows[1]],
expect.any(Object),
);
expect(onExpand).toHaveBeenNthCalledWith(
Expand Down
56 changes: 35 additions & 21 deletions packages/itwinui-react/src/core/Table/Table.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ import {
useMergedRefs,
useLatestRef,
useVirtualScroll,
WithCSSTransition,
} from '../../utils/index.js';
import type { CommonProps } from '../../utils/index.js';
import { TableColumnsContext } from './utils.js';
Expand Down Expand Up @@ -66,6 +67,7 @@ import {
import { SELECTION_CELL_ID } from './columns/index.js';
import { Virtualizer, type VirtualItem } from '@tanstack/react-virtual';
import { ColumnHeader } from './ColumnHeader.js';
import { TableExpandableContentMemoized } from './TableExpandableContentMemoized.js';

const singleRowSelectedAction = 'singleRowSelected';
const shiftRowSelectedAction = 'shiftRowSelected';
Expand Down Expand Up @@ -835,27 +837,39 @@ export const Table = <
const row = page[index];
prepareRow(row);
return (
<TableRowMemoized
row={row}
rowProps={rowProps}
isLast={index === page.length - 1}
onRowInViewport={onRowInViewportRef}
onBottomReached={onBottomReachedRef}
intersectionMargin={intersectionMargin}
state={state}
key={row.getRowProps().key}
onClick={onRowClickHandler}
subComponent={subComponent}
isDisabled={!!isRowDisabled?.(row.original)}
tableHasSubRows={hasAnySubRows}
tableInstance={instance}
expanderCell={expanderCell}
scrollContainerRef={tableRef.current}
tableRowRef={enableVirtualization ? undefined : tableRowRef(row)}
density={density}
virtualItem={virtualItem}
virtualizer={virtualizer}
/>
<>
<TableRowMemoized
row={row}
rowProps={rowProps}
isLast={index === page.length - 1}
onRowInViewport={onRowInViewportRef}
onBottomReached={onBottomReachedRef}
intersectionMargin={intersectionMargin}
state={state}
key={row.getRowProps().key}
onClick={onRowClickHandler}
subComponent={subComponent}
isDisabled={!!isRowDisabled?.(row.original)}
tableHasSubRows={hasAnySubRows}
tableInstance={instance}
expanderCell={expanderCell}
scrollContainerRef={tableRef.current}
tableRowRef={enableVirtualization ? undefined : tableRowRef(row)}
density={density}
virtualItem={virtualItem}
virtualizer={virtualizer}
/>
{subComponent && (
<WithCSSTransition in={row.isExpanded}>
<TableExpandableContentMemoized
key={row.getRowProps().key}
ref={tableRowRef(row)}
>
{subComponent(row)}
</TableExpandableContentMemoized>
</WithCSSTransition>
)}
</>
);
},
[
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*---------------------------------------------------------------------------------------------
* Copyright (c) Bentley Systems, Incorporated. All rights reserved.
* See LICENSE.md in the project root for license terms and full copyright notice.
*--------------------------------------------------------------------------------------------*/
import cx from 'classnames';
import * as React from 'react';
import { Box } from '../../utils/index.js';
import type { PolymorphicForwardRefComponent } from '../../utils/index.js';

type TableExpandableContentProps = {
children: React.ReactNode;
};

const TableExpandableContent = React.forwardRef((props, ref) => {
const { children, className, style, ...rest } = props;
return (
<Box
className={cx('iui-table-row', 'iui-table-expanded-content', className)}
style={{
flex: '0 0 auto',
minWidth: '100%',
...style,
}}
ref={ref}
{...rest}
>
{children}
</Box>
);
}) as PolymorphicForwardRefComponent<'div', TableExpandableContentProps>;

export const TableExpandableContentMemoized = React.memo(
TableExpandableContent,
);
17 changes: 1 addition & 16 deletions packages/itwinui-react/src/core/Table/TableRowMemoized.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,7 @@ import type {
TableInstance,
TableState,
} from '../../react-table/react-table.js';
import {
Box,
useIntersection,
useMergedRefs,
WithCSSTransition,
} from '../../utils/index.js';
import { Box, useIntersection, useMergedRefs } from '../../utils/index.js';
import { TableCell } from './TableCell.js';
import type { Virtualizer, VirtualItem } from '@tanstack/react-virtual';

Expand Down Expand Up @@ -153,16 +148,6 @@ export const TableRow = <T extends Record<string, unknown>>(props: {
);
})}
</Box>
{subComponent && (
<WithCSSTransition in={row.isExpanded}>
<Box
className={cx('iui-table-row', 'iui-table-expanded-content')}
aria-disabled={isDisabled}
>
{subComponent(row)}
</Box>
</WithCSSTransition>
)}
</>
);
};
Expand Down
Loading