Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ibexa/*] Added symfony/notifier subscriptions #127

Merged
merged 2 commits into from
Jul 24, 2024
Merged

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jul 4, 2024

🎫 Issue IBX-8137

Related PRs:

ibexa/user#84

Description:

For QA:

Documentation:

Copy link

github-actions bot commented Jul 4, 2024

Thanks for contribution! 🎉

To test the changes please execute:

composer config extra.symfony.endpoint https://api.github.com/repos/ibexa/recipes-dev/contents/index.json?ref=flex/pull-127

before executing the recipes.

@Steveb-p Steveb-p requested a review from a team July 4, 2024 10:56
Comment on lines +126 to +127
channels:
- email
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question - this doesn't seem to be used in ibexa/user. We seem to always send an email (based on what I saw in the PR). Is this correct? Are we even making use of this setting?

Copy link

sonarcloud bot commented Jul 8, 2024

@ViniTou ViniTou changed the title IBX-8137: Added User related subscriptions [ibexa/*] Added symfony/notifier subscriptions Jul 8, 2024
@webhdx webhdx requested a review from a team July 9, 2024 08:29
@tomaszszopinski tomaszszopinski self-assigned this Jul 24, 2024
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 5.0

@ViniTou ViniTou merged commit 3f300ea into master Jul 24, 2024
2 checks passed
@ViniTou ViniTou deleted the ibx-8137-mailer branch July 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants