Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8137: Moved from swift mailer to symfony mailer #84

Merged
merged 6 commits into from
Jul 24, 2024
Merged

IBX-8137: Moved from swift mailer to symfony mailer #84

merged 6 commits into from
Jul 24, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Jul 3, 2024 •
edited
Loading

🎫 Issue IBX-8137

Related PRs:

Description:

For QA:

Documentation:

@ViniTou ViniTou requested a review from a team July 4, 2024 07:04
@ViniTou ViniTou mentioned this pull request Jul 4, 2024
Merged
Steveb-p
Steveb-p approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general. Remarks are optional.

src/contracts/Notification/UserInvitation.php Outdated Show resolved Hide resolved
src/lib/Invitation/MailSender.php Show resolved Hide resolved
konradoboza
konradoboza approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, but I would personally start switching to the new PHP8 features (like constructor property promotion) whenever an old code is touched.

src/contracts/Notification/UserInvitation.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team July 4, 2024 11:40
@ViniTou ViniTou mentioned this pull request Jul 10, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

tomaszszopinski
tomaszszopinski approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP commerce 5.0

@ViniTou ViniTou merged commit 536f68b into main Jul 24, 2024
12 checks passed
@ViniTou ViniTou deleted the ibx-8137-drop-swiftmailer branch July 24, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@mikadamczyk mikadamczyk

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ViniTou @adamwojs @Steveb-p @konradoboza @tomaszszopinski @mikadamczyk